Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 25089002: Fix webfont loading fallback height issue (for m30) (Closed)

Created:
7 years, 2 months ago by Xianzhu
Modified:
7 years, 2 months ago
Reviewers:
CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, dglazkov+blink, Rik, Stephen Chennney, jeez, pdr.
Visibility:
Public.

Description

Fix webfont loading fallback height issue (for m30) When a webfont is loading, a temporary font is created which may be used to calculate the layout height of the text and override the correct fallback font. To prevent that, skip the temporary font in FontFallbackList::primaryFontData(). FIXME: remaining issues: 1. When the webfont is the only font face in the CSS font-family, the fallback font is still incorrect when the webfont is loading; 2. When the fallback font is monospace, when it is fell back to, the default font-size doesn't match (16px vs 13px). BUG=299010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M Source/core/platform/graphics/FontFallbackList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/FontFallbackList.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698