- Add special access for receiver as it is a frequently used operation

- Add special access for receiver as it is a frequently used operation
- Merge closure/instance function bitfields into one bitfield to simplify
  access to arguments.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28028

[regis, 2013-09-27 19:34:39]

LGTM

https://chromiumcodereview.appspot.com/25062003/diff/9001/runtime/vm/native_a...
File runtime/vm/native_arguments.h (right):

https://chromiumcodereview.appspot.com/25062003/diff/9001/runtime/vm/native_a...
runtime/vm/native_arguments.h:113: return NativeReceiver();
I would add a comment that calling NativeReceiver() on a static function will
return the first argument without error.
Doing this internally is fine, but it is somewhat surprising to let the user do
it. You probably do not want to add a check, maybe an assert and then inline
NativeReceiver here without the assert? I'm fine either way.

[siva, 2013-09-27 21:12:37]

https://chromiumcodereview.appspot.com/25062003/diff/9001/runtime/vm/native_a...
File runtime/vm/native_arguments.h (right):

https://chromiumcodereview.appspot.com/25062003/diff/9001/runtime/vm/native_a...
runtime/vm/native_arguments.h:113: return NativeReceiver();
Good point.

As discussed offline I have added a private helper method to
get argument 0 and in NativeReceiver I have an assert that it is
not about to invoke a static method.

On 2013/09/27 19:34:39, regis wrote:
> I would add a comment that calling NativeReceiver() on a static function will
> return the first argument without error.
> Doing this internally is fine, but it is somewhat surprising to let the user
do
> it. You probably do not want to add a check, maybe an assert and then inline
> NativeReceiver here without the assert? I'm fine either way.

[siva, 2013-09-27 22:22:26]

Committed patchset #3 manually as r28028 (presubmit successful).