Reduce code duplication in IC updating.

Reduce code duplication in IC updating.

BUG=
R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17034

[Toon Verwaest, 2013-09-27 15:13:19]

PTAL

[ulan, 2013-09-30 14:06:46]

https://chromiumcodereview.appspot.com/25033003/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/25033003/diff/1/src/objects.h#newcode4877
src/objects.h:4877: return static_cast<Kind>(arguments_count());
I didn't get this part. Why are we using arguments_count as kind and where is it
set?

[Toon Verwaest, 2013-09-30 14:09:09]

https://chromiumcodereview.appspot.com/25033003/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/25033003/diff/1/src/objects.h#newcode4877
src/objects.h:4877: return static_cast<Kind>(arguments_count());
This is something that still needs to be cleaned up.

It's a deprecated way of using the argc as extended extra IC state. It's put
there in BaseLoadStoreStubCompiler::GetCode:
   Code::Flags flags = Code::ComputeFlags(
       Code::HANDLER, MONOMORPHIC, extra_state(), type, kind);

kind is the argc of the flags.

On 2013/09/30 14:06:46, ulan wrote:
> I didn't get this part. Why are we using arguments_count as kind and where is
it
> set?

[ulan, 2013-09-30 14:43:15]

LGTM

[Toon Verwaest, 2013-10-01 09:30:18]

Committed patchset #1 manually as r17034 (presubmit successful).