Reduce code duplication in IC updating.

src/objects.h

Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 8a48116f99f77e76726ec5cd8f47a604b754bd12..145895b8f61ce82d3af62b6f2c5462b29da4fb52 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -4873,6 +4873,9 @@ class Code: public HeapObject {
 
   // [flags]: Access to specific code flags.
   inline Kind kind();
+  inline Kind handler_kind() {
+    return static_cast<Kind>(arguments_count());

[ulan, 2013/09/30 14:06:46]

I didn't get this part. Why are we using arguments_count as kind and where is it
set?

[Toon Verwaest, 2013/09/30 14:09:09]

This is something that still needs to be cleaned up.

It's a deprecated way of using the argc as extended extra IC state. It's put
there in BaseLoadStoreStubCompiler::GetCode:
   Code::Flags flags = Code::ComputeFlags(
       Code::HANDLER, MONOMORPHIC, extra_state(), type, kind);

kind is the argc of the flags.

On 2013/09/30 14:06:46, ulan wrote:

+  }
   inline InlineCacheState ic_state();  // Only valid for IC stubs.
   inline ExtraICState extra_ic_state();  // Only valid for IC stubs.
 
@@ -4891,6 +4894,7 @@ class Code: public HeapObject {
   // Testers for IC stub kinds.
   inline bool is_inline_cache_stub();
   inline bool is_debug_stub();
+  inline bool is_handler() { return kind() == HANDLER; }
   inline bool is_load_stub() { return kind() == LOAD_IC; }
   inline bool is_keyed_load_stub() { return kind() == KEYED_LOAD_IC; }
   inline bool is_store_stub() { return kind() == STORE_IC; }