Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24982002: Clean up ContainerNode exception messages. (Closed)

Created:
7 years, 2 months ago by Mike West
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Clean up ContainerNode exception messages. The externally visible strings should read 'Node'; 'ContainerNode' is an impl. detail. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158430

Patch Set 1 #

Patch Set 2 : rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -51 lines) Patch
M LayoutTests/fast/dom/DOMException/prototype-object.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/DOMException/prototype-object-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/DOMException/stack-trace.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/DOMException/stack-trace-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Document/replaceChild-null-oldChild-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLTemplateElement/cycles-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/incompatible-operations.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/incompatible-operations-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/setter-type-enforcement-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-hierarchy-exception-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-append-child.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-append-child-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-insert-before.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-insert-before-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-replace-child.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-replace-child-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-replace-child-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-replace-child-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/remove-target-with-shadow-in-drag-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/inspector-support/uncaught-dom3-exception-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/inspector-support/uncaught-dom8-exception-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/dot-node-base-exception-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/script-tests/dot-node-base-exception.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 11 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Hi Jochen, here's a followup to https://codereview.chromium.org/23889039/ to clean up a mistake Erik noticed. Mind ...
7 years, 2 months ago (2013-09-27 08:23:54 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-09-27 08:25:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/24982002/3001
7 years, 2 months ago (2013-09-27 08:26:20 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 09:19:49 UTC) #4
Message was sent while issue was closed. 
Change committed as 158430

Powered by Google App Engine
This is Rietveld 408576698