Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 24918002: Converted the remaining GPU bots to recipes. (Closed)

Created:
7 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 2 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, Mike Stip (use stip instead), bajones, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Converted the remaining GPU bots to recipes. This includes the GPU bots on the chromium.gpu.fyi, tryserver.chromium, and chromium.webkit waterfalls. Tested with runit.py/runbuild.py --show-commands against each of the affected bots, and ensured the correct annotator step was printed. Also tested the try job path through the GPU recipe locally. Note that some of the affected bots are in bad shape right now, but the plan is to work on these bots after the switch. BUG=286398 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225769

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -431 lines) Patch
M masters/master.chromium.gpu.fyi/master.cfg View 6 chunks +29 lines, -99 lines 2 comments Download
M masters/master.chromium.gpu.fyi/slaves.cfg View 5 chunks +5 lines, -0 lines 0 comments Download
M masters/master.chromium.gpu/master.cfg View 2 chunks +1 line, -18 lines 2 comments Download
M masters/master.chromium.webkit/master.cfg View 2 chunks +2 lines, -6 lines 0 comments Download
A masters/master.chromium.webkit/master_gpu_latest_cfg.py View 1 chunk +66 lines, -0 lines 0 comments Download
D masters/master.chromium.webkit/master_linux_gpu_latest_cfg.py View 1 chunk +0 lines, -88 lines 0 comments Download
D masters/master.chromium.webkit/master_mac_gpu_latest_cfg.py View 1 chunk +0 lines, -80 lines 0 comments Download
D masters/master.chromium.webkit/master_win_gpu_latest_cfg.py View 1 chunk +0 lines, -81 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 3 chunks +9 lines, -59 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
7 years, 2 months ago (2013-09-27 00:50:08 UTC) #1
iannucci
lgtm
7 years, 2 months ago (2013-09-27 08:25:55 UTC) #2
agable
LGTM. I love how much static configuration just got kicked out of these masters. https://codereview.chromium.org/24918002/diff/1/masters/master.chromium.gpu.fyi/master.cfg ...
7 years, 2 months ago (2013-09-27 19:57:26 UTC) #3
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/24918002/diff/1/masters/master.chromium.gpu.fyi/master.cfg File masters/master.chromium.gpu.fyi/master.cfg (right): https://codereview.chromium.org/24918002/diff/1/masters/master.chromium.gpu.fyi/master.cfg#newcode89 masters/master.chromium.gpu.fyi/master.cfg:89: # TODO(kbr): rtoy: switch the Audio bots to use ...
7 years, 2 months ago (2013-09-27 20:30:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/24918002/1
7 years, 2 months ago (2013-09-27 20:30:43 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 20:31:37 UTC) #6
Message was sent while issue was closed.
Change committed as 225769

Powered by Google App Engine
This is Rietveld 408576698