Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 24874002: Have all skia platforms share FontPlatformData::hash() implementation (Closed)

Created:
7 years, 2 months ago by eae
Modified:
7 years, 2 months ago
CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, Stephen Chennney, jeez, pdr.
Visibility:
Public.

Description

Have all skia platforms share FontPlatformData::hash() implementation Update Windows to use a SkTypeface based hash value for FontPlatformData when the non-GDI path is used. Move the existing implementation from FontPlatformDataHarfBuzz to FontPlatformDataSkia to allow and to ensure that all skia platforms share the same implementation. Also, rename m_size to m_textSiz for FontPlatformDataChromiumWin to be consistent with the other platforms. R=bungeman@chromium.org BUG=249099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158495

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -28 lines) Patch
M Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.h View 3 chunks +7 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/platform/graphics/skia/FontPlatformDataSkia.cpp View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eae
7 years, 2 months ago (2013-09-27 18:37:38 UTC) #1
eae
7 years, 2 months ago (2013-09-27 19:13:36 UTC) #2
eseidel
lgtm
7 years, 2 months ago (2013-09-27 21:33:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/24874002/9001
7 years, 2 months ago (2013-09-27 21:33:52 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 2 months ago (2013-09-28 04:17:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/24874002/9001
7 years, 2 months ago (2013-09-28 16:07:41 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-28 16:08:15 UTC) #7
Message was sent while issue was closed.
Change committed as 158495

Powered by Google App Engine
This is Rietveld 408576698