Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp - Issue 24874002: Have all skia platforms share FontPlatformData::hash() implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp

Issue 24874002: Have all skia platforms share FontPlatformData::hash() implementation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp ('k') | Source/core/platform/graphics/skia/FontPlatformDataSkia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp

diff --git a/Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp b/Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp

index e86b3416a043de5dbefdbfdffac218352d9d6eb2..8bca56d200efac9cd5368121579712af127eadbe 100644

--- a/Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp

+++ b/Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp

@@ -240,21 +240,6 @@ bool FontPlatformData::operator==(const FontPlatformData& a) const

&& m_isHashTableDeletedValue == a.m_isHashTableDeletedValue;

}

-unsigned FontPlatformData::hash() const

- unsigned h = SkTypeface::UniqueID(m_typeface.get());

- h ^= 0x01010101 * ((static_cast<int>(m_orientation) << 2) | (static_cast<int>(m_fakeBold) << 1) | static_cast<int>(m_fakeItalic));

- // This memcpy is to avoid a reinterpret_cast that breaks strict-aliasing

- // rules. Memcpy is generally optimized enough so that performance doesn't

- // matter here.

- uint32_t textSizeBytes;

- memcpy(&textSizeBytes, &m_textSize, sizeof(uint32_t));

- h ^= textSizeBytes;

- return h;

bool FontPlatformData::isFixedPitch() const

{

notImplemented();