Source/core/dom/ContainerNodeAlgorithms.h - Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNodeAlgorithms.h

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ContainerNodeAlgorithms.h

diff --git a/Source/core/dom/ContainerNodeAlgorithms.h b/Source/core/dom/ContainerNodeAlgorithms.h

index d8910cfb7da6a59c7007091e0e2366946b7e9cbb..6247bcc8da93253958c159a1ea2e6e84d2e2b233 100644

--- a/Source/core/dom/ContainerNodeAlgorithms.h

+++ b/Source/core/dom/ContainerNodeAlgorithms.h

@@ -228,7 +228,7 @@ inline void ChildNodeInsertionNotifier::notify(Node* node)

// were inserted.

// FIXME: We should merge the lazy attach logic into the tree traversal in

// notifyNodeInsertedIntoDocument.

- if (!node->attached() && node->parentNode() && node->parentNode()->attached())

+ if (!node->confusingAndOftenMisusedAttached() && node->parentNode() && node->parentNode()->confusingAndOftenMisusedAttached())

node->lazyAttach();

for (size_t i = 0; i < m_postInsertionNotificationTargets.size(); ++i) {

« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »