Source/bindings/v8/NPV8Object.cpp - Issue 24758003: ScriptController: limit script execution API to executeScript and callFunction, pass valid ScriptEx…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/NPV8Object.cpp

Issue 24758003: ScriptController: limit script execution API to executeScript and callFunction, pass valid ScriptEx… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: w/ ScheduledAction executing in given context. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/NPV8Object.cpp

diff --git a/Source/bindings/v8/NPV8Object.cpp b/Source/bindings/v8/NPV8Object.cpp

index ef02215cd046f144932cc0e6ab4d8f04fd8e2f2d..6289b3410a34d2ec95f519ad938a9e34a40450ea 100644

--- a/Source/bindings/v8/NPV8Object.cpp

+++ b/Source/bindings/v8/NPV8Object.cpp

@@ -355,7 +355,7 @@ bool _NPN_EvaluateHelper(NPP npp, bool popupsAllowed, NPObject* npObject, NPStri

String script = String::fromUTF8(npScript->UTF8Characters, npScript->UTF8Length);

UserGestureIndicator gestureIndicator(popupsAllowed ? DefinitelyProcessingNewUserGesture : PossiblyProcessingUserGesture);

- v8::Local<v8::Value> v8result = frame->script()->compileAndRunScript(ScriptSourceCode(script, KURL(ParsedURLString, filename)));

+ v8::Local<v8::Value> v8result = frame->script()->executeScriptAndReturnValue(context, ScriptSourceCode(script, KURL(ParsedURLString, filename)));

if (v8result.IsEmpty())

return false;

« no previous file with comments | « no previous file | Source/bindings/v8/ScheduledAction.cpp » ('j') | no next file with comments »