Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24758003: ScriptController: limit script execution API to executeScript and callFunction, pass valid ScriptEx… (Closed)

Created:
7 years, 2 months ago by pfeldman
Modified:
7 years, 2 months ago
CC:
blink-reviews, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, johnjbarton
Visibility:
Public.

Description

ScriptController: limit script execution API to executeScript and callFunction, pass valid ScriptExecutionContext into ::callFunction. BUG=297619 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158437

Patch Set 1 #

Patch Set 2 : Lint #

Patch Set 3 : w/ ScheduledAction executing in given context. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -36 lines) Patch
M Source/bindings/v8/NPV8Object.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScheduledAction.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptController.h View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 1 2 6 chunks +6 lines, -16 lines 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/bindings/v8/V8Callback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8ErrorHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8NodeFilterCondition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
7 years, 2 months ago (2013-09-26 15:46:23 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-09-27 08:31:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/24758003/8001
7 years, 2 months ago (2013-09-27 11:14:02 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 12:07:47 UTC) #4
Message was sent while issue was closed. 
Change committed as 158437

Powered by Google App Engine
This is Rietveld 408576698