Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: tests/pending_manager_test.py

Issue 24495008: False -> 'False' to fix CQ crash loop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pending_manager.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/pending_manager_test.py
diff --git a/tests/pending_manager_test.py b/tests/pending_manager_test.py
index efef86f109eee3ce27deaafa82782c19fbd198f0..4c0190a79e069b70ff46d99195f9312187fab4d1 100755
--- a/tests/pending_manager_test.py
+++ b/tests/pending_manager_test.py
@@ -113,7 +113,7 @@ class TestPendingManager(mocks.TestCase):
'apply_patch(%r)' % (self.context.rietveld.patchsets[0],)])
self.context.rietveld.check_calls(
[ _try_comment(),
- "set_flag(%d, 1, 'commit', False)" % issue,
+ "set_flag(%d, 1, 'commit', 'False')" % issue,
"add_comment(%d, %r)" % (issue, pc.FAILED_NO_MESSAGE)])
else:
if success:
@@ -130,11 +130,11 @@ class TestPendingManager(mocks.TestCase):
if defered:
self.context.rietveld.check_calls(
[ _try_comment(),
- "set_flag(%d, 1, 'commit', False)" % issue,
+ "set_flag(%d, 1, 'commit', 'False')" % issue,
"add_comment(%d, %r)" % (issue, pc.FAILED_NO_MESSAGE)])
else:
self.context.rietveld.check_calls(
- [ "set_flag(%d, 1, 'commit', False)" % issue,
+ [ "set_flag(%d, 1, 'commit', 'False')" % issue,
"add_comment(%d, %r)" % (issue, pc.FAILED_NO_MESSAGE)])
def _prepare_apply_commit(self, index, issue, server_hooks_missing=False):
@@ -621,7 +621,7 @@ class TestPendingManager(mocks.TestCase):
pc.update_status()
self.assertEqual(0, len(pc.queue.iterate()))
self.context.rietveld.check_calls(
- [ "set_flag(%d, 1, 'commit', False)" % issue,
+ [ "set_flag(%d, 1, 'commit', 'False')" % issue,
"add_comment(%d, %r)" % (issue, reviewer_lgtm.LgtmStatus.NO_LGTM)])
self.context.status.check_names(['abort'])
@@ -661,7 +661,7 @@ class TestPendingManager(mocks.TestCase):
pc.scan_results()
self.context.rietveld.check_calls(
[ _try_comment(),
- "set_flag(%d, 1, 'commit', False)" % issue,
+ "set_flag(%d, 1, 'commit', 'False')" % issue,
('add_comment(%d, "List of reviewers changed. annoying@dude.org '
'did a drive-by without LGTM\'ing!")') % issue])
self.context.status.check_names(['initial', 'abort'])
« no previous file with comments | « pending_manager.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698