pending_manager.py - Issue 24495008: False -> 'False' to fix CQ crash loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pending_manager.py

Issue 24495008: False -> 'False' to fix CQ crash loop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pending_manager.py

diff --git a/pending_manager.py b/pending_manager.py

index a11c4a4052da98677f1c6869a67c906730a82e82..d8682c5b45e5b12418ff461a376631443930e8fe 100644

--- a/pending_manager.py

+++ b/pending_manager.py

@@ -405,7 +405,7 @@ class PendingManager(object):

try:

if pending.get_state() != base.IGNORED:

self.context.rietveld.set_flag(

- pending.issue, pending.patchset, 'commit', False)

+ pending.issue, pending.patchset, 'commit', 'False')

except urllib2.HTTPError as e:

logging.error(

'Failed to set the flag to False for %s with message %s' % (

« no previous file with comments | « no previous file | tests/pending_manager_test.py » ('j') | no next file with comments »