Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 24493004: Make dialog::backdrop span the viewport by default. (Closed)

Created:
7 years, 3 months ago by falken
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Make dialog::backdrop span the viewport by default. As per the recent spec change: http://html5.org/r/8197 No new test, covered by modifying modal-dialog-backdrop.html Existing tests that don't test backdrop specifically are modified to have display: none backdrops. BUG=140205 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M LayoutTests/dialog/inert-node-is-not-highlighted.html View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/dialog/modal-dialog-backdrop.html View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/dialog/removed-element-is-removed-from-top-layer.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/dialog/top-layer-containing-block.html View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/dialog/top-layer-display-none.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/dialog/top-layer-nesting.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/dialog/top-layer-stacking.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/dialog/top-layer-stacking-correct-order-remove-readd.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/dialog/top-layer-stacking-dynamic.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Hi Kent-san, Can you please review?
7 years, 3 months ago (2013-09-25 05:29:20 UTC) #1
tkent
lgtm
7 years, 3 months ago (2013-09-25 05:32:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/24493004/1
7 years, 3 months ago (2013-09-25 05:52:43 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-25 08:55:15 UTC) #4
Message was sent while issue was closed.
Change committed as 158311

Powered by Google App Engine
This is Rietveld 408576698