Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: Source/core/rendering/RenderTheme.cpp

Issue 24493004: Make dialog::backdrop span the viewport by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 490
491 if (RuntimeEnabledFeatures::inputTypeColorEnabled()) { 491 if (RuntimeEnabledFeatures::inputTypeColorEnabled()) {
492 runtimeCSS.appendLiteral("input[type=\"color\"][list] { -webkit-appe arance: menulist; width: 88px; height: 23px;}"); 492 runtimeCSS.appendLiteral("input[type=\"color\"][list] { -webkit-appe arance: menulist; width: 88px; height: 23px;}");
493 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch-wrapper { padding-left: 8px; padding-right: 24px;}"); 493 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch-wrapper { padding-left: 8px; padding-right: 24px;}");
494 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch { border-color: #000000;}"); 494 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch { border-color: #000000;}");
495 } 495 }
496 } 496 }
497 if (RuntimeEnabledFeatures::dialogElementEnabled()) { 497 if (RuntimeEnabledFeatures::dialogElementEnabled()) {
498 runtimeCSS.appendLiteral("dialog:not([open]) { display: none; }"); 498 runtimeCSS.appendLiteral("dialog:not([open]) { display: none; }");
499 runtimeCSS.appendLiteral("dialog { position: absolute; left: 0; right: 0 ; width: -webkit-fit-content; height: -webkit-fit-content; margin: auto; border: solid; padding: 1em; background: white; color: black;}"); 499 runtimeCSS.appendLiteral("dialog { position: absolute; left: 0; right: 0 ; width: -webkit-fit-content; height: -webkit-fit-content; margin: auto; border: solid; padding: 1em; background: white; color: black;}");
500 runtimeCSS.appendLiteral("dialog::backdrop { background: rgba(0,0,0,0.1) ; }"); 500 runtimeCSS.appendLiteral("dialog::backdrop { position: fixed; top: 0; ri ght: 0; bottom: 0; left: 0; background: rgba(0,0,0,0.1); }");
501 } 501 }
502 502
503 return runtimeCSS.toString(); 503 return runtimeCSS.toString();
504 } 504 }
505 505
506 String RenderTheme::formatMediaControlsTime(float time) const 506 String RenderTheme::formatMediaControlsTime(float time) const
507 { 507 {
508 if (!std::isfinite(time)) 508 if (!std::isfinite(time))
509 time = 0; 509 time = 0;
510 int seconds = (int)fabsf(time); 510 int seconds = (int)fabsf(time);
(...skipping 867 matching lines...) Expand 10 before | Expand all | Expand 10 after
1378 1378
1379 // padding - not honored by WinIE, needs to be removed. 1379 // padding - not honored by WinIE, needs to be removed.
1380 style->resetPadding(); 1380 style->resetPadding();
1381 1381
1382 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 1382 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
1383 // for now, we will not honor it. 1383 // for now, we will not honor it.
1384 style->resetBorder(); 1384 style->resetBorder();
1385 } 1385 }
1386 1386
1387 } // namespace WebCore 1387 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698