Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2447893002: Remove remnants of libsrtp1 (Closed)

Created:
4 years, 1 month ago by mattdr-at-webrtc.org
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove remnants of libsrtp1 Now that Chromium has taken libsrtp2, remove any compatibility bridge code in WebRTC that was only needed for libsrtp1. Remove SRTP_RELATIVE_PATH now that Google's internal copy of libsrtp and the Chromium copy have the same directory structure. Fix some include orderings per the Chromium C++ style guide. Remove the `extern "C"` blocks now that the libsrtp headers include them (https://github.com/cisco/libsrtp/pull/195). BUG=webrtc:6376 Committed: https://crrev.com/0d8ade543d45412dfdcc6482870d52b81ebc348a Cr-Commit-Position: refs/heads/master@{#14776}

Patch Set 1 #

Patch Set 2 : include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -83 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/externalhmac.h View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/pc/externalhmac.cc View 1 3 chunks +2 lines, -37 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/srtpfilter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 1 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
mattdr-at-webrtc.org
4 years, 1 month ago (2016-10-24 21:47:40 UTC) #7
kjellander_webrtc
lgtm but you need someone from https://chromium.googlesource.com/external/webrtc/+/master/webrtc/pc/OWNERS to approve as well. Thanks so much for ...
4 years, 1 month ago (2016-10-25 06:50:27 UTC) #8
kjellander_webrtc
adding perkj@webrtc.org for webrtc/pc
4 years, 1 month ago (2016-10-25 06:51:02 UTC) #10
perkj_webrtc
lgtm
4 years, 1 month ago (2016-10-25 06:56:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2447893002/20001
4 years, 1 month ago (2016-10-25 16:46:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 16:47:29 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:15:27 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d8ade543d45412dfdcc6482870d52b81ebc348a
Cr-Commit-Position: refs/heads/master@{#14776}

Powered by Google App Engine
This is Rietveld 408576698