Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2447473002: Fix std::memset usage in blob_memory_controller_unittest.cc. (Closed)

Created:
4 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
dmurph
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix std::memset usage in blob_memory_controller_unittest.cc. This change exchanges the 2nd and 3rd parameters to std::memset() in a number of places where the value to set and the length of the buffer were inverted. The resulting incompletely initialized buffers triggered MSan failures. BUG=375297 TBR=dmurph@chromium.org Committed: https://crrev.com/0c79c5f5b228452450aa542ff33d0b49209ee429 Cr-Commit-Position: refs/heads/master@{#426966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/blob_storage/blob_memory_controller_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447473002/1
4 years, 2 months ago (2016-10-22 01:51:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-22 03:50:37 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 03:53:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c79c5f5b228452450aa542ff33d0b49209ee429
Cr-Commit-Position: refs/heads/master@{#426966}

Powered by Google App Engine
This is Rietveld 408576698