Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: content/browser/blob_storage/blob_memory_controller_unittest.cc

Issue 2447473002: Fix std::memset usage in blob_memory_controller_unittest.cc. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/blob_storage/blob_memory_controller_unittest.cc
diff --git a/content/browser/blob_storage/blob_memory_controller_unittest.cc b/content/browser/blob_storage/blob_memory_controller_unittest.cc
index e5132cb12b7f8cc4c37b8130cfbe0994e61e525f..6b68cbda66c75f1222288183e87ef77007f95160 100644
--- a/content/browser/blob_storage/blob_memory_controller_unittest.cc
+++ b/content/browser/blob_storage/blob_memory_controller_unittest.cc
@@ -218,7 +218,7 @@ TEST_F(BlobMemoryControllerTest, PageToDisk) {
SetTestMemoryLimits(&controller);
char kData[kTestBlobStorageMaxBlobMemorySize];
- std::memset(kData, kTestBlobStorageMaxBlobMemorySize, 'e');
+ std::memset(kData, 'e', kTestBlobStorageMaxBlobMemorySize);
// Add memory item that is the memory quota.
BlobDataBuilder builder(kId);
@@ -306,7 +306,7 @@ TEST_F(BlobMemoryControllerTest, CancelMemoryRequest) {
SetTestMemoryLimits(&controller);
char kData[kTestBlobStorageMaxBlobMemorySize];
- std::memset(kData, kTestBlobStorageMaxBlobMemorySize, 'e');
+ std::memset(kData, 'e', kTestBlobStorageMaxBlobMemorySize);
// Add memory item that is the memory quota.
BlobDataBuilder builder(kId);
@@ -366,7 +366,7 @@ TEST_F(BlobMemoryControllerTest, FileRequest) {
SetTestMemoryLimits(&controller);
char kData[kBlobSize];
- std::memset(kData, kBlobSize, 'e');
+ std::memset(kData, 'e', kBlobSize);
// Add item that is the file quota.
BlobDataBuilder builder(kId);
@@ -423,7 +423,7 @@ TEST_F(BlobMemoryControllerTest, CancelFileRequest) {
SetTestMemoryLimits(&controller);
char kData[kBlobSize];
- std::memset(kData, kBlobSize, 'e');
+ std::memset(kData, 'e', kBlobSize);
// Add memory item that is the memory quota.
BlobDataBuilder builder(kId);
@@ -607,7 +607,7 @@ TEST_F(BlobMemoryControllerTest, DisableDiskWithFileAndMemoryPending) {
SetTestMemoryLimits(&controller);
char kDataMemoryData[kFirstMemorySize];
- std::memset(kDataMemoryData, kFirstMemorySize, 'e');
+ std::memset(kDataMemoryData, 'e', kFirstMemorySize);
// Add first memory item to fill up some memory quota.
BlobDataBuilder builder(kFirstMemoryId);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698