Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: Source/modules/webdatabase/SQLTransactionBackendSync.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/SQLTransactionBackendSync.cpp
diff --git a/Source/modules/webdatabase/SQLTransactionBackendSync.cpp b/Source/modules/webdatabase/SQLTransactionBackendSync.cpp
index d844fbb102cc5dd45d0542da4c44c41852b3ae42..1d6322281320137f681ab12ad32aab1f6dc9607e 100644
--- a/Source/modules/webdatabase/SQLTransactionBackendSync.cpp
+++ b/Source/modules/webdatabase/SQLTransactionBackendSync.cpp
@@ -158,7 +158,7 @@ void SQLTransactionBackendSync::begin(ExceptionState& es)
m_database->setLastErrorMessage("unable to begin transaction",
m_database->sqliteDatabase().lastError(), m_database->sqliteDatabase().lastErrorMsg());
m_sqliteTransaction.clear();
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
return;
}
@@ -171,7 +171,7 @@ void SQLTransactionBackendSync::begin(ExceptionState& es)
m_database->setLastErrorMessage("unable to read version",
m_database->sqliteDatabase().lastError(), m_database->sqliteDatabase().lastErrorMsg());
rollback();
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
return;
}
m_hasVersionMismatch = !m_database->expectedVersion().isEmpty() && (m_database->expectedVersion() != actualVersion);
@@ -213,7 +213,7 @@ void SQLTransactionBackendSync::commit(ExceptionState& es)
m_database->reportCommitTransactionResult(2, SQLError::DATABASE_ERR, m_database->sqliteDatabase().lastError());
m_database->setLastErrorMessage("unable to commit transaction",
m_database->sqliteDatabase().lastError(), m_database->sqliteDatabase().lastErrorMsg());
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
return;
}
« no previous file with comments | « Source/modules/webdatabase/SQLTransaction.cpp ('k') | Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698