Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: Source/modules/webaudio/AudioNode.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/DefaultAudioDestinationNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioNode.cpp
diff --git a/Source/modules/webaudio/AudioNode.cpp b/Source/modules/webaudio/AudioNode.cpp
index cc88387fe4acf00ef093f073ceaa65e3767775b3..0e66fd12f366797aac7a1b8de3ae1f9cfc7fffc1 100644
--- a/Source/modules/webaudio/AudioNode.cpp
+++ b/Source/modules/webaudio/AudioNode.cpp
@@ -130,23 +130,23 @@ void AudioNode::connect(AudioNode* destination, unsigned outputIndex, unsigned i
AudioContext::AutoLocker locker(context());
if (!destination) {
- es.throwDOMException(SyntaxError);
+ es.throwUninformativeAndGenericDOMException(SyntaxError);
return;
}
// Sanity check input and output indices.
if (outputIndex >= numberOfOutputs()) {
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return;
}
if (destination && inputIndex >= destination->numberOfInputs()) {
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return;
}
if (context() != destination->context()) {
- es.throwDOMException(SyntaxError);
+ es.throwUninformativeAndGenericDOMException(SyntaxError);
return;
}
@@ -164,17 +164,17 @@ void AudioNode::connect(AudioParam* param, unsigned outputIndex, ExceptionState&
AudioContext::AutoLocker locker(context());
if (!param) {
- es.throwDOMException(SyntaxError);
+ es.throwUninformativeAndGenericDOMException(SyntaxError);
return;
}
if (outputIndex >= numberOfOutputs()) {
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return;
}
if (context() != param->context()) {
- es.throwDOMException(SyntaxError);
+ es.throwUninformativeAndGenericDOMException(SyntaxError);
return;
}
@@ -189,7 +189,7 @@ void AudioNode::disconnect(unsigned outputIndex, ExceptionState& es)
// Sanity check input and output indices.
if (outputIndex >= numberOfOutputs()) {
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return;
}
@@ -214,7 +214,7 @@ void AudioNode::setChannelCount(unsigned long channelCount, ExceptionState& es)
updateChannelsForInputs();
}
} else {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
}
}
@@ -246,7 +246,7 @@ void AudioNode::setChannelCountMode(const String& mode, ExceptionState& es)
else if (mode == "explicit")
m_channelCountMode = Explicit;
else
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
if (m_channelCountMode != oldMode)
updateChannelsForInputs();
@@ -274,7 +274,7 @@ void AudioNode::setChannelInterpretation(const String& interpretation, Exception
else if (interpretation == "discrete")
m_channelInterpretation = AudioBus::Discrete;
else
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
}
void AudioNode::updateChannelsForInputs()
« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/DefaultAudioDestinationNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698