Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2206)

Unified Diff: Source/modules/mediasource/WebKitMediaSource.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.cpp ('k') | Source/modules/mediasource/WebKitSourceBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediasource/WebKitMediaSource.cpp
diff --git a/Source/modules/mediasource/WebKitMediaSource.cpp b/Source/modules/mediasource/WebKitMediaSource.cpp
index 860a2938dba29f12910fe7bb275a8a1ac891108a..77b42231aabab943bf5f14d1e56d1244d8c928df 100644
--- a/Source/modules/mediasource/WebKitMediaSource.cpp
+++ b/Source/modules/mediasource/WebKitMediaSource.cpp
@@ -75,21 +75,21 @@ WebKitSourceBuffer* WebKitMediaSource::addSourceBuffer(const String& type, Excep
// 1. If type is null or an empty then throw an InvalidAccessError exception and
// abort these steps.
if (type.isNull() || type.isEmpty()) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return 0;
}
// 2. If type contains a MIME type that is not supported ..., then throw a
// NotSupportedError exception and abort these steps.
if (!isTypeSupported(type)) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
// 4. If the readyState attribute is not in the "open" state then throw an
// InvalidStateError exception and abort these steps.
if (!isOpen()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return 0;
}
@@ -114,14 +114,14 @@ void WebKitMediaSource::removeSourceBuffer(WebKitSourceBuffer* buffer, Exception
// 1. If sourceBuffer is null then throw an InvalidAccessError exception and
// abort these steps.
if (!buffer) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return;
}
// 2. If sourceBuffers is empty then throw an InvalidStateError exception and
// abort these steps.
if (isClosed() || !m_sourceBuffers->length()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
@@ -130,7 +130,7 @@ void WebKitMediaSource::removeSourceBuffer(WebKitSourceBuffer* buffer, Exception
// 6. Remove sourceBuffer from sourceBuffers and fire a removesourcebuffer event
// on that object.
if (!m_sourceBuffers->remove(buffer)) {
- es.throwDOMException(NotFoundError);
+ es.throwUninformativeAndGenericDOMException(NotFoundError);
return;
}
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.cpp ('k') | Source/modules/mediasource/WebKitSourceBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698