Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: Source/modules/mediasource/MediaSourceBase.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediasource/MediaSource.cpp ('k') | Source/modules/mediasource/SourceBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediasource/MediaSourceBase.cpp
diff --git a/Source/modules/mediasource/MediaSourceBase.cpp b/Source/modules/mediasource/MediaSourceBase.cpp
index 370d7b3c9120dc291656ccda5a9bd63a7b5a948a..ad004c7402c0e687680c42bf82304e359d7ff3aa 100644
--- a/Source/modules/mediasource/MediaSourceBase.cpp
+++ b/Source/modules/mediasource/MediaSourceBase.cpp
@@ -144,11 +144,11 @@ PassRefPtr<TimeRanges> MediaSourceBase::buffered() const
void MediaSourceBase::setDuration(double duration, ExceptionState& es)
{
if (duration < 0.0 || std::isnan(duration)) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return;
}
if (!isOpen()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
@@ -188,7 +188,7 @@ void MediaSourceBase::endOfStream(const AtomicString& error, ExceptionState& es)
// 1. If the readyState attribute is not in the "open" state then throw an
// InvalidStateError exception and abort these steps.
if (!isOpen()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
@@ -201,7 +201,7 @@ void MediaSourceBase::endOfStream(const AtomicString& error, ExceptionState& es)
} else if (error == decode) {
eosStatus = MediaSourcePrivate::EosDecodeError;
} else {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return;
}
@@ -271,13 +271,13 @@ PassOwnPtr<SourceBufferPrivate> MediaSourceBase::createSourceBufferPrivate(const
// Step 2: If type contains a MIME type ... that is not supported with the types
// specified for the other SourceBuffer objects in sourceBuffers, then throw
// a NotSupportedError exception and abort these steps.
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return nullptr;
case MediaSourcePrivate::ReachedIdLimit:
// 2.2 https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#widl-MediaSource-addSourceBuffer-SourceBuffer-DOMString-type
// Step 3: If the user agent can't handle any more SourceBuffer objects then throw
// a QuotaExceededError exception and abort these steps.
- es.throwDOMException(QuotaExceededError);
+ es.throwUninformativeAndGenericDOMException(QuotaExceededError);
return nullptr;
}
« no previous file with comments | « Source/modules/mediasource/MediaSource.cpp ('k') | Source/modules/mediasource/SourceBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698