Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: Source/core/testing/InternalSettings.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/properties/SVGTransformListPropertyTearOff.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/InternalSettings.cpp
diff --git a/Source/core/testing/InternalSettings.cpp b/Source/core/testing/InternalSettings.cpp
index 33c45eb4a23c95d24d45e91eef03a4299d811ad9..4d6263354ed41b07ab0d989b577d73350aa6a51a 100644
--- a/Source/core/testing/InternalSettings.cpp
+++ b/Source/core/testing/InternalSettings.cpp
@@ -38,19 +38,19 @@
#define InternalSettingsGuardForSettingsReturn(returnValue) \
if (!settings()) { \
- es.throwDOMException(InvalidAccessError); \
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError); \
return returnValue; \
}
#define InternalSettingsGuardForSettings() \
if (!settings()) { \
- es.throwDOMException(InvalidAccessError); \
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError); \
return; \
}
#define InternalSettingsGuardForPage() \
if (!page()) { \
- es.throwDOMException(InvalidAccessError); \
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError); \
return; \
}
@@ -294,7 +294,7 @@ void InternalSettings::setEditingBehavior(const String& editingBehavior, Excepti
else if (equalIgnoringCase(editingBehavior, "android"))
settings()->setEditingBehaviorType(EditingAndroidBehavior);
else
- es.throwDOMException(SyntaxError);
+ es.throwUninformativeAndGenericDOMException(SyntaxError);
}
void InternalSettings::setLangAttributeAwareFormControlUIEnabled(bool enabled)
« no previous file with comments | « Source/core/svg/properties/SVGTransformListPropertyTearOff.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698