Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSMatrix.cpp ('k') | Source/core/css/CSSStyleSheet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSPrimitiveValue.cpp
diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp
index 9a5741efa55ed33871e858c231ce883e78eccf63..fa13edae56c734355daaf951b3bf5f872813f3d8 100644
--- a/Source/core/css/CSSPrimitiveValue.cpp
+++ b/Source/core/css/CSSPrimitiveValue.cpp
@@ -629,7 +629,7 @@ void CSSPrimitiveValue::setFloatValue(unsigned short, double, ExceptionState& es
// Keeping values immutable makes optimizations easier and allows sharing of the primitive value objects.
// No other engine supports mutating style through this API. Computed style is always read-only anyway.
// Supporting setter would require making primitive value copy-on-write and taking care of style invalidation.
- es.throwDOMException(NoModificationAllowedError);
+ es.throwUninformativeAndGenericDOMException(NoModificationAllowedError);
}
double CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor(unsigned short unitType)
@@ -689,7 +689,7 @@ double CSSPrimitiveValue::getDoubleValue(unsigned short unitType, ExceptionState
double result = 0;
bool success = getDoubleValueInternal(static_cast<UnitTypes>(unitType), &result);
if (!success) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return 0.0;
}
@@ -789,7 +789,7 @@ void CSSPrimitiveValue::setStringValue(unsigned short, const String&, ExceptionS
// Keeping values immutable makes optimizations easier and allows sharing of the primitive value objects.
// No other engine supports mutating style through this API. Computed style is always read-only anyway.
// Supporting setter would require making primitive value copy-on-write and taking care of style invalidation.
- es.throwDOMException(NoModificationAllowedError);
+ es.throwUninformativeAndGenericDOMException(NoModificationAllowedError);
}
String CSSPrimitiveValue::getStringValue(ExceptionState& es) const
@@ -805,7 +805,7 @@ String CSSPrimitiveValue::getStringValue(ExceptionState& es) const
case CSS_PROPERTY_ID:
return propertyName(m_value.propertyID);
default:
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
break;
}
@@ -834,7 +834,7 @@ String CSSPrimitiveValue::getStringValue() const
Counter* CSSPrimitiveValue::getCounterValue(ExceptionState& es) const
{
if (m_primitiveUnitType != CSS_COUNTER) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return 0;
}
@@ -844,7 +844,7 @@ Counter* CSSPrimitiveValue::getCounterValue(ExceptionState& es) const
Rect* CSSPrimitiveValue::getRectValue(ExceptionState& es) const
{
if (m_primitiveUnitType != CSS_RECT) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return 0;
}
@@ -854,7 +854,7 @@ Rect* CSSPrimitiveValue::getRectValue(ExceptionState& es) const
Quad* CSSPrimitiveValue::getQuadValue(ExceptionState& es) const
{
if (m_primitiveUnitType != CSS_QUAD) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return 0;
}
@@ -864,7 +864,7 @@ Quad* CSSPrimitiveValue::getQuadValue(ExceptionState& es) const
PassRefPtr<RGBColor> CSSPrimitiveValue::getRGBColorValue(ExceptionState& es) const
{
if (m_primitiveUnitType != CSS_RGBCOLOR) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return 0;
}
@@ -875,7 +875,7 @@ PassRefPtr<RGBColor> CSSPrimitiveValue::getRGBColorValue(ExceptionState& es) con
Pair* CSSPrimitiveValue::getPairValue(ExceptionState& es) const
{
if (m_primitiveUnitType != CSS_PAIR) {
- es.throwDOMException(InvalidAccessError);
+ es.throwUninformativeAndGenericDOMException(InvalidAccessError);
return 0;
}
« no previous file with comments | « Source/core/css/CSSMatrix.cpp ('k') | Source/core/css/CSSStyleSheet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698