Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2446433002: Cleanups to remove an unnecessary parameter in LayoutBox::mapScrollingContentsRectToBoxSpace. (Closed)
Patch Set: none Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 599c5ec4d7ad2e485a0f2c19eed9195c36ac21df..9bb04a993e62ab288ebeb0f8cc56f97fcd5c7f9d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -1152,14 +1152,10 @@ LayoutRect LayoutBox::clippingRect() const {
bool LayoutBox::mapScrollingContentsRectToBoxSpace(
LayoutRect& rect,
- ApplyOverflowClipFlag applyOverflowClip,
VisualRectFlags visualRectFlags) const {
if (!hasClipRelatedProperty())
return true;
- if (applyOverflowClip == ApplyNonScrollOverflowClip)
- return true;
-
if (hasOverflowClip()) {
LayoutSize offset = LayoutSize(-scrolledContentOffset());
rect.move(offset);
@@ -2370,11 +2366,9 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(
// we use the values cached by the layer.
rect.setLocation(topLeft);
- if (container->isBox() &&
+ if (container->isBox() && container != ancestor &&
!toLayoutBox(container)->mapScrollingContentsRectToBoxSpace(
- rect, container == ancestor ? ApplyNonScrollOverflowClip
- : ApplyOverflowClip,
- visualRectFlags))
+ rect, visualRectFlags))
return false;
if (ancestorSkipped) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.h ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698