third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 2446433002: Cleanups to remove an unnecessary parameter in LayoutBox::mapScrollingContentsRectToBoxSpace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 2446433002: Cleanups to remove an unnecessary parameter in LayoutBox::mapScrollingContentsRectToBoxSpace. (Closed)

Patch Set: none Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index 19ac47476b6db7945f4398c23c95b8de0474d753..b8a5ed449df5133bab6be3ce2edbed67f2478998 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -1213,11 +1213,8 @@ bool LayoutInline::mapToVisualRectInAncestorSpace(

LayoutBox* containerBox =

container->isBox() ? toLayoutBox(container) : nullptr;

- if (containerBox &&

- !containerBox->mapScrollingContentsRectToBoxSpace(

- rect, container == ancestor ? ApplyNonScrollOverflowClip

- : ApplyOverflowClip,

- visualRectFlags))

+ if (containerBox && container != ancestor &&

+ !containerBox->mapScrollingContentsRectToBoxSpace(rect, visualRectFlags))

return false;

// TODO(wkorman): Generalize Ruby specialization and/or document more clearly.