Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2446433002: Cleanups to remove an unnecessary parameter in LayoutBox::mapScrollingContentsRectToBoxSpace. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanups to remove an unnecessary parameter in LayoutBox::mapScrollingContentsRectToBoxSpace. Committed: https://crrev.com/e30a06a83c6c7df7ef4def824f8153f8123daed6 Cr-Commit-Position: refs/heads/master@{#426950}

Patch Set 1 #

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -24 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
chrishtr
4 years, 2 months ago (2016-10-21 21:03:29 UTC) #3
pdr.
On 2016/10/21 at 21:03:29, chrishtr wrote: > Best patch award http://i.imgur.com/CR0jTty.jpg LGTM
4 years, 2 months ago (2016-10-21 21:06:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446433002/20001
4 years, 2 months ago (2016-10-21 21:10:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-22 02:03:31 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 02:07:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e30a06a83c6c7df7ef4def824f8153f8123daed6
Cr-Commit-Position: refs/heads/master@{#426950}

Powered by Google App Engine
This is Rietveld 408576698