Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2442723002: [modules] Check more invariants for Module objects in heap verifier. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Check more invariants for Module objects in heap verifier. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/dd614f55ce36f9bd12f429bd8b69f24e974d0547 Cr-Commit-Position: refs/heads/master@{#40508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/objects-debug.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 2 months ago (2016-10-21 11:02:26 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-10-21 13:08:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442723002/1
4 years, 2 months ago (2016-10-21 13:09:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 13:39:35 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd614f55ce36f9bd12f429bd8b69f24e974d0547
Cr-Commit-Position: refs/heads/master@{#40508}

Powered by Google App Engine
This is Rietveld 408576698