Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: src/objects-debug.cc

Issue 2442723002: [modules] Check more invariants for Module objects in heap verifier. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 179e92f21a3600054a335501344dd49b44ef47cb..362fa4074c199f55a3fbac6b414802a0289327dd 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -1015,8 +1015,13 @@ void Module::ModuleVerify() {
CHECK(module_namespace()->IsUndefined(GetIsolate()) ||
module_namespace()->IsJSModuleNamespace());
+ if (module_namespace()->IsJSModuleNamespace()) {
+ CHECK_EQ(JSModuleNamespace::cast(module_namespace())->module(), this);
+ }
+
+ CHECK_EQ(requested_modules()->length(), info()->module_requests()->length());
- // TODO(neis): Check more.
+ CHECK_NE(hash(), 0);
}
void PrototypeInfo::PrototypeInfoVerify() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698