Implement fade-out animation for Aura overlay scrollbars (CC only).

Implement fade-out animation for Aura overlay scrollbars (CC only).

This change implements the fade out animation in the scroll animation
controller used for Aura overlay scrollbars. It only affects composited
scrollers for now.

This change makes the thinning controller responsible for scheduling two
animations: fading and thinning. It does this by making sure that only one
animation is ever running at a time and making sure to schedule a fade at the
end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/6cd8cd30ad46f2ac0f9064289f876c73b050dddd
Cr-Commit-Position: refs/heads/master@{#426711}

[bokan, 2016-10-20 21:40:13]

Description was changed from

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
  composited scrollers.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
==========

to

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
  composited scrollers.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[bokan, 2016-10-20 22:07:05]

Description was changed from

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
  composited scrollers.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
composited scrollers.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[bokan, 2016-10-20 22:07:20]

Description was changed from

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
composited scrollers.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
composited scrollers.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[bokan, 2016-10-20 22:11:58]

Description was changed from

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
composited scrollers.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
composited scrollers. This means the thinning controller is actually
responsible for scheduling two animations: fading and thinning. It does this by
making sure that only one animation is ever running at a time and making sure
to schedule a fade at the end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[bokan, 2016-10-20 22:59:28]

Description was changed from

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This implements the fade out animation in the scroll animation controller used
for Aura overlay scrollbars. The effect is currently only available for
composited scrollers. This means the thinning controller is actually
responsible for scheduling two animations: fading and thinning. It does this by
making sure that only one animation is ever running at a time and making sure
to schedule a fade at the end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This change implements the fade out animation in the scroll animation
controller used for Aura overlay scrollbars. It only affects composited
scrollers for now.

This change makes the thinning controller responsible for scheduling two
animations: fading and thinning. It does this by making sure that only one
animation is ever running at a time and making sure to schedule a fade at the
end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[bokan, 2016-10-20 22:59:29]

bokan@chromium.org changed reviewers:
+ aelias@chromium.org

[bokan, 2016-10-20 23:02:04]

Alexandre, ptal.

In a future patch (tracked in crbug.com/656606) we'll merge all the animators
into a single one where the thinning can be turned off for Clank. For now though
this gets us the fading behavior for Aura.

[aelias_OOO_until_Jul13, 2016-10-20 23:40:51]

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller.cc (right):

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller.cc:63: // TODO(bokan): When do we get
ScrollUpdates without a ScrollBegin? This may
Any kind of main-thread scroll (JS, history or gesture handling).

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller.h (right):

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller.h:66: base::TimeDelta duration_;
Could you replace this with a pure virtual getter, and move this state to
ScrollbarAnimationControllerLinearFade?

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_thinning.h (right):

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_thinning.h:72: bool is_visible_;
Hmm, I don't generally like "visible" booleans due to their many possible subtle
meanings.  Could you just store "float opacity" and check "if (opacity == 0.0f)"
in the various places?

[bokan, 2016-10-21 00:32:31]

ptal

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller.cc (right):

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller.cc:63: // TODO(bokan): When do we get
ScrollUpdates without a ScrollBegin? This may
On 2016/10/20 23:40:51, aelias wrote:
> Any kind of main-thread scroll (JS, history or gesture handling).

Got it, thanks. Removed TODO and added a test.

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller.h (right):

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller.h:66: base::TimeDelta duration_;
On 2016/10/20 23:40:51, aelias wrote:
> Could you replace this with a pure virtual getter, and move this state to
> ScrollbarAnimationControllerLinearFade?

You mean move the state into both descendant classes right? Done.

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_thinning.h (right):

https://codereview.chromium.org/2442573002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_thinning.h:72: bool is_visible_;
On 2016/10/20 23:40:51, aelias wrote:
> Hmm, I don't generally like "visible" booleans due to their many possible
subtle
> meanings.  Could you just store "float opacity" and check "if (opacity ==
0.0f)"
> in the various places?

Done.

[aelias_OOO_until_Jul13, 2016-10-21 00:44:03]

lgtm

[bokan, 2016-10-21 00:49:40]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2016-10-21 00:50:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:39:28]

Description was changed from

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This change implements the fade out animation in the scroll animation
controller used for Aura overlay scrollbars. It only affects composited
scrollers for now.

This change makes the thinning controller responsible for scheduling two
animations: fading and thinning. It does this by making sure that only one
animation is ever running at a time and making sure to schedule a fade at the
end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This change implements the fade out animation in the scroll animation
controller used for Aura overlay scrollbars. It only affects composited
scrollers for now.

This change makes the thinning controller responsible for scheduling two
animations: fading and thinning. It does this by making sure that only one
animation is ever running at a time and making sure to schedule a fade at the
end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-21 03:39:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:26:50]

Description was changed from

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This change implements the fade out animation in the scroll animation
controller used for Aura overlay scrollbars. It only affects composited
scrollers for now.

This change makes the thinning controller responsible for scheduling two
animations: fading and thinning. It does this by making sure that only one
animation is ever running at a time and making sure to schedule a fade at the
end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Implement fade-out animation for Aura overlay scrollbars (CC only).

This change implements the fade out animation in the scroll animation
controller used for Aura overlay scrollbars. It only affects composited
scrollers for now.

This change makes the thinning controller responsible for scheduling two
animations: fading and thinning. It does this by making sure that only one
animation is ever running at a time and making sure to schedule a fade at the
end of a thinning animation if needed.

This patch removes the animated opacity changes between different hover states
since they're no longer part of the specified behavior. It adds a simpler
animated fade out similar to the "linear fade" controller when the scroller is
idle for some time.

It also cleans up the tests for the thinning controller, using constants where
appropriate and making most tests oblivious to animation timing.

BUG=652826
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/6cd8cd30ad46f2ac0f9064289f876c73b050dddd
Cr-Commit-Position: refs/heads/master@{#426711}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:51]

Patchset 4 (id:??) landed as
https://crrev.com/6cd8cd30ad46f2ac0f9064289f876c73b050dddd
Cr-Commit-Position: refs/heads/master@{#426711}