Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2440853002: Mac: Add command line flag to disable AVFoundation layers (Closed)

Created:
4 years, 2 months ago by ccameron
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, mac-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Add command line flag to disable AVFoundation layers This is useful in debugging problems. BUG=652409 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5666e3260f2ca02ca5ff615a6f4720de62cf690a Cr-Commit-Position: refs/heads/master@{#427227}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 3 chunks +12 lines, -5 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ccameron
Adding zmo for content/browser/gpu/
4 years, 2 months ago (2016-10-20 23:37:46 UTC) #3
ccameron
ping
4 years, 1 month ago (2016-10-24 21:03:23 UTC) #4
Zhenyao Mo
lgtm https://codereview.chromium.org/2440853002/diff/1/content/browser/gpu/gpu_process_host.cc File content/browser/gpu/gpu_process_host.cc (right): https://codereview.chromium.org/2440853002/diff/1/content/browser/gpu/gpu_process_host.cc#newcode160 content/browser/gpu/gpu_process_host.cc:160: switches::kDisableGpuDriverBugWorkarounds}; Actually the original style is correct - ...
4 years, 1 month ago (2016-10-24 21:41:20 UTC) #5
ccameron
https://codereview.chromium.org/2440853002/diff/1/content/browser/gpu/gpu_process_host.cc File content/browser/gpu/gpu_process_host.cc (right): https://codereview.chromium.org/2440853002/diff/1/content/browser/gpu/gpu_process_host.cc#newcode160 content/browser/gpu/gpu_process_host.cc:160: switches::kDisableGpuDriverBugWorkarounds}; On 2016/10/24 21:41:20, Zhenyao Mo wrote: > Actually ...
4 years, 1 month ago (2016-10-24 21:42:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440853002/20001
4 years, 1 month ago (2016-10-24 21:54:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 01:42:36 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:44:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5666e3260f2ca02ca5ff615a6f4720de62cf690a
Cr-Commit-Position: refs/heads/master@{#427227}

Powered by Google App Engine
This is Rietveld 408576698