[heap] Move typed slot filtering logic into sweeper.

[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering and black area end markers.

BUG=chromium:648568
Committed: https://crrev.com/a007dfc18e95a79cba33cd2e850ddf650853752d
Cr-Commit-Position: refs/heads/master@{#40494}

[Hannes Payer (out of office), 2016-10-20 10:28:03]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 10:28:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 10:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 10:37:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Hannes Payer (out of office), 2016-10-20 12:14:11]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 12:14:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-10-20 12:17:38]

Description was changed from

==========
[heap] Move slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering.

BUG=chromium:648568
==========

to

==========
[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering.

BUG=chromium:648568
==========

[commit-bot: I haz the power, 2016-10-20 12:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 12:19:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Hannes Payer (out of office), 2016-10-20 13:30:37]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 13:30:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 13:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 13:35:40]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Hannes Payer (out of office), 2016-10-20 13:37:59]

Description was changed from

==========
[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering.

BUG=chromium:648568
==========

to

==========
[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering and black
area end markers.

BUG=chromium:648568
==========

[Hannes Payer (out of office), 2016-10-20 13:43:42]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 13:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-10-20 13:48:16]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org, ulan@chromium.org

[ulan, 2016-10-20 15:48:19]

Looking good!

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/mark-co...
File src/heap/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/mark-co...
src/heap/mark-compact.cc:3223: std::map<uint32_t, uint32_t> free_ranges;
Alternative solution was to have host_objects of typed slots in std::map and
then remove them at line 3377. Are you going to implement this later?

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/slot-set.h
File src/heap/slot-set.h (right):

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/slot-se...
src/heap/slot-set.h:472: invalid_ranges.upper_bound(host_offset);
if (upper_bound == invalid_ranges.begin()) continue;
Could you also add a test for this case?

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/slot-se...
src/heap/slot-set.h:476: if (upper_bound->first <= host_offset &&
DCHECK_LE(upper_bound->first, host_offset);
This should be guaranteed by the upper_bound() function.

[Michael Lippautz, 2016-10-20 16:28:24]

Looking good.

+1 to what Ulan found in the clearing function!

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/mark-co...
File src/heap/mark-compact.cc (left):

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/mark-co...
src/heap/mark-compact.cc:2875: bool
MarkCompactCollector::IsSlotInBlackObject(MemoryChunk* p, Address slot) {
I would like to express my deepest gratitude for deleting this one, sir!

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/mark-co...
File src/heap/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/2440683002/diff/80001/src/heap/mark-co...
src/heap/mark-compact.cc:3312:
p->typed_old_to_new_slots()->RemoveInvaldSlots(free_ranges);
This call should go outside of the last if block as far as I see, as we don't
enter it anymore if free_start == p->area_end which happens when there is no
free space at the end of the page.

[Hannes Payer (out of office), 2016-10-21 07:12:54]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 07:13:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-10-21 07:13:30]

https://codereview.chromium.org/2440683002/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/2440683002/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:2875: bool
MarkCompactCollector::IsSlotInBlackObject(MemoryChunk* p, Address slot) {
On 2016/10/20 16:28:24, Michael Lippautz wrote:
> I would like to express my deepest gratitude for deleting this one, sir!

Drinks are on you :D

https://codereview.chromium.org/2440683002/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2440683002/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3223: std::map<uint32_t, uint32_t> free_ranges;
On 2016/10/20 15:48:19, ulan wrote:
> Alternative solution was to have host_objects of typed slots in std::map and
> then remove them at line 3377. Are you going to implement this later?
> 

Are you referring to the solution where you
1) transfer objects from remembered set into map
2) remove live objects from map
3) filter based on dead objects
?

I implemented the current one because it is dual to the regular slot set
filtering. The only problem with it is that there may be quite some map entries.
Are you worried about that?

The current solution only iterates over the remembered set once, that's another
advantage. But I am happy to change it.

https://codereview.chromium.org/2440683002/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3312:
p->typed_old_to_new_slots()->RemoveInvaldSlots(free_ranges);
On 2016/10/20 16:28:24, Michael Lippautz wrote:
> This call should go outside of the last if block as far as I see, as we don't
> enter it anymore if free_start == p->area_end which happens when there is no
> free space at the end of the page.

Uh, good catch. Too many branches. Done

https://codereview.chromium.org/2440683002/diff/80001/src/heap/slot-set.h
File src/heap/slot-set.h (right):

https://codereview.chromium.org/2440683002/diff/80001/src/heap/slot-set.h#new...
src/heap/slot-set.h:472: invalid_ranges.upper_bound(host_offset);
On 2016/10/20 15:48:19, ulan wrote:
> if (upper_bound == invalid_ranges.begin()) continue;
> Could you also add a test for this case?

Done.

https://codereview.chromium.org/2440683002/diff/80001/src/heap/slot-set.h#new...
src/heap/slot-set.h:476: if (upper_bound->first <= host_offset &&
On 2016/10/20 15:48:19, ulan wrote:
> DCHECK_LE(upper_bound->first, host_offset);
> This should be guaranteed by the upper_bound() function.

Done.

[commit-bot: I haz the power, 2016-10-21 07:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 07:30:14]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Hannes Payer (out of office), 2016-10-21 07:51:41]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 07:51:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 08:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 08:44:52]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-10-21 08:53:39]

lgtm if ulan is fine with the clearing approach

[ulan, 2016-10-21 08:59:29]

lgtm!

We discussed the clearing with Hannes. The number of free ranges is small in
practice, so the approach looks good.

[Hannes Payer (out of office), 2016-10-21 09:00:10]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2016-10-21 09:00:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-10-21 09:00:55]

octane: maximum 156, average 34 free ranges
similar for web workloads.

[commit-bot: I haz the power, 2016-10-21 09:04:54]

Description was changed from

==========
[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering and black
area end markers.

BUG=chromium:648568
==========

to

==========
[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering and black
area end markers.

BUG=chromium:648568
==========

[commit-bot: I haz the power, 2016-10-21 09:04:55]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-17 22:09:19]

Description was changed from

==========
[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering and black
area end markers.

BUG=chromium:648568
==========

to

==========
[heap] Move typed slot filtering logic into sweeper.

Additionally, remove all code related to the old-style slots filtering and black
area end markers.

BUG=chromium:648568

Committed: https://crrev.com/a007dfc18e95a79cba33cd2e850ddf650853752d
Cr-Commit-Position: refs/heads/master@{#40494}
==========

[commit-bot: I haz the power, 2016-11-17 22:09:21]

Patchset 7 (id:??) landed as
https://crrev.com/a007dfc18e95a79cba33cd2e850ddf650853752d
Cr-Commit-Position: refs/heads/master@{#40494}