Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: src/heap/spaces.h

Issue 2440683002: [heap] Move typed slot filtering logic into sweeper. (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/slot-set.h ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index a66f3394d3117585a1fd8af755b4cc54448464bb..7d379490d9323f61f0d607453d5e8d11d76fab81 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -343,9 +343,7 @@ class MemoryChunk {
+ kPointerSize // AtomicValue prev_chunk_
// FreeListCategory categories_[kNumberOfCategories]
+ FreeListCategory::kSize * kNumberOfCategories +
- kPointerSize // LocalArrayBufferTracker* local_tracker_
- // std::unordered_set<Address>* black_area_end_marker_map_
- + kPointerSize;
+ kPointerSize; // LocalArrayBufferTracker* local_tracker_
// We add some more space to the computed header size to amount for missing
// alignment requirements in our computation.
@@ -576,33 +574,6 @@ class MemoryChunk {
void InsertAfter(MemoryChunk* other);
void Unlink();
- void ReleaseBlackAreaEndMarkerMap() {
- if (black_area_end_marker_map_) {
- delete black_area_end_marker_map_;
- black_area_end_marker_map_ = nullptr;
- }
- }
-
- bool IsBlackAreaEndMarker(Address address) {
- if (black_area_end_marker_map_) {
- return black_area_end_marker_map_->find(address) !=
- black_area_end_marker_map_->end();
- }
- return false;
- }
-
- void AddBlackAreaEndMarker(Address address) {
- if (!black_area_end_marker_map_) {
- black_area_end_marker_map_ = new std::unordered_set<Address>();
- }
- auto ret = black_area_end_marker_map_->insert(address);
- USE(ret);
- // Check that we inserted a new black area end marker.
- DCHECK(ret.second);
- }
-
- bool HasBlackAreas() { return black_area_end_marker_map_ != nullptr; }
-
protected:
static MemoryChunk* Initialize(Heap* heap, Address base, size_t size,
Address area_start, Address area_end,
@@ -669,9 +640,6 @@ class MemoryChunk {
LocalArrayBufferTracker* local_tracker_;
- // Stores the end addresses of black areas.
- std::unordered_set<Address>* black_area_end_marker_map_;
-
private:
void InitializeReservedMemory() { reservation_.Reset(); }
« no previous file with comments | « src/heap/slot-set.h ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698