Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2440503002: Don't WaitForNavigate in memory.blink_memory_mobile benchmark. (Closed)

Created:
4 years, 2 months ago by bokan
Modified:
4 years, 2 months ago
Reviewers:
nednguyen, bashi
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't WaitForNavigate in memory.blink_memory_mobile benchmark. Since https://codereview.chromium.org/2400123002 has landed, the navigate step waits for an additional frame before returning. I suspect the redirect navigations happen in that frame so when the page calls WaitForNavigate it'll timeout. BUG=655627 Committed: https://crrev.com/7319aef904a71aba9f710482b8372434b8227df6 Cr-Commit-Position: refs/heads/master@{#426480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/page_sets/blink_memory_mobile.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bokan
bashi@, you wrote this so I hope you're the right reviewer. The NavigateAction now waits ...
4 years, 2 months ago (2016-10-19 17:46:02 UTC) #3
bashi
non-owner lgtm
4 years, 2 months ago (2016-10-19 23:35:15 UTC) #4
bokan
+nednguyen@ for OWNER
4 years, 2 months ago (2016-10-20 14:25:52 UTC) #6
nednguyen
lgtm
4 years, 2 months ago (2016-10-20 14:28:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440503002/1
4 years, 2 months ago (2016-10-20 14:29:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 15:26:26 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:18:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7319aef904a71aba9f710482b8372434b8227df6
Cr-Commit-Position: refs/heads/master@{#426480}

Powered by Google App Engine
This is Rietveld 408576698