tools/perf/page_sets/blink_memory_mobile.py - Issue 2440503002: Don't WaitForNavigate in memory.blink_memory_mobile benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/blink_memory_mobile.py

Issue 2440503002: Don't WaitForNavigate in memory.blink_memory_mobile benchmark. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/blink_memory_mobile.py

diff --git a/tools/perf/page_sets/blink_memory_mobile.py b/tools/perf/page_sets/blink_memory_mobile.py

index 3c38d9e627f304807a8ca73fdf0b4af8324a4719..e6c53c948feeafe8d8b30749db3892e4a8eeb98b 100644

--- a/tools/perf/page_sets/blink_memory_mobile.py

+++ b/tools/perf/page_sets/blink_memory_mobile.py

@@ -81,8 +81,6 @@ class GmailPage(BlinkMemoryMobilePage):

google_login.LoginGoogleAccount(action_runner, 'google',

self.credentials_path)

super(GmailPage, self).RunNavigateSteps(action_runner)

- # Needs to wait for navigation to handle redirects.

- action_runner.WaitForNavigate()

action_runner.WaitForElement(selector='#apploadingdiv')

action_runner.WaitForJavaScriptCondition(

'document.querySelector("#apploadingdiv").style.opacity == "0"')

« no previous file with comments | « no previous file | no next file » | no next file with comments »