Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2439863002: Prevent cross-thread refcounting for thread-unsafe IndexedDBCallbacks. (Closed)

Created:
4 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
jsbell, cmumford
CC:
chromium-reviews, cmumford, darin-cc_chromium.org, jam, jsbell+idb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent cross-thread refcounting for thread-unsafe IndexedDBCallbacks. This object is refcounted but is not thread safe. Transfering ownership of the first reference (since it is created on the IO thread) to the callback should prevent issues. BUG=657862 Committed: https://crrev.com/a7233873f6fa93ddf414555f7d60f9baba71cd0e Cr-Commit-Position: refs/heads/master@{#426583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -26 lines) Patch
M content/browser/indexed_db/indexed_db_callbacks.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 13 chunks +33 lines, -16 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.cc View 6 chunks +17 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 2 months ago (2016-10-20 19:10:53 UTC) #3
jsbell
lgtm
4 years, 2 months ago (2016-10-20 19:25:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439863002/1
4 years, 2 months ago (2016-10-20 19:32:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 20:33:42 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:22:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7233873f6fa93ddf414555f7d60f9baba71cd0e
Cr-Commit-Position: refs/heads/master@{#426583}

Powered by Google App Engine
This is Rietveld 408576698