Prevent cross-thread refcounting for thread-unsafe IndexedDBCallbacks.

content/browser/indexed_db/indexed_db_callbacks.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_callbacks.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 82 matching lines @@
     IndexedDBDispatcherHost* dispatcher_host,
     const url::Origin& origin,
     ::indexed_db::mojom::CallbacksAssociatedPtrInfo callbacks_info)
     : dispatcher_host_(dispatcher_host),
       ipc_cursor_id_(kNoCursor),
       host_transaction_id_(kNoTransaction),
       origin_(origin),
       ipc_database_id_(kNoDatabase),
       data_loss_(blink::WebIDBDataLossNone),
       sent_blocked_(false),
-      io_helper_(new IOThreadHelper(std::move(callbacks_info))) {}
+      io_helper_(new IOThreadHelper(std::move(callbacks_info))) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  thread_checker_.DetachFromThread();
+}
 
-IndexedDBCallbacks::~IndexedDBCallbacks() {}
+IndexedDBCallbacks::~IndexedDBCallbacks() {
+  DCHECK(thread_checker_.CalledOnValidThread());
+}
 
 void IndexedDBCallbacks::OnError(const IndexedDBDatabaseError& error) {
-  DCHECK(dispatcher_host_.get());
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
 
   if (io_helper_) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&IOThreadHelper::SendError,
                    base::Unretained(io_helper_.get()), error));
   } else {
     dispatcher_host_->Send(new IndexedDBMsg_CallbacksError(
         ipc_thread_id_, ipc_callbacks_id_, error.code(), error.message()));
   }
   dispatcher_host_ = nullptr;
 
   if (!connection_open_start_time_.is_null()) {
     UMA_HISTOGRAM_MEDIUM_TIMES(
         "WebCore.IndexedDB.OpenTime.Error",
         base::TimeTicks::Now() - connection_open_start_time_);
     connection_open_start_time_ = base::TimeTicks();
   }
 }
 
 void IndexedDBCallbacks::OnSuccess(const std::vector<base::string16>& value) {
-  DCHECK(dispatcher_host_.get());
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(io_helper_);
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&IOThreadHelper::SendSuccessStringList,
                  base::Unretained(io_helper_.get()), value));
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnBlocked(int64_t existing_version) {
-  DCHECK(dispatcher_host_.get());
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(io_helper_);
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
 
   if (sent_blocked_)
     return;
 
   sent_blocked_ = true;
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&IOThreadHelper::SendBlocked,
                  base::Unretained(io_helper_.get()), existing_version));
 
   if (!connection_open_start_time_.is_null()) {
     UMA_HISTOGRAM_MEDIUM_TIMES(
         "WebCore.IndexedDB.OpenTime.Blocked",
         base::TimeTicks::Now() - connection_open_start_time_);
     connection_open_start_time_ = base::TimeTicks();
   }
 }
 
 void IndexedDBCallbacks::OnUpgradeNeeded(
     int64_t old_version,
     std::unique_ptr<IndexedDBConnection> connection,
     const IndexedDBDatabaseMetadata& metadata,
     const IndexedDBDataLossInfo& data_loss_info) {
-  DCHECK(dispatcher_host_.get());
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(io_helper_);
   DCHECK_NE(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
 
   data_loss_ = data_loss_info.status;
   dispatcher_host_->RegisterTransactionId(host_transaction_id_, origin_);
   int32_t ipc_database_id =
       dispatcher_host_->Add(connection.release(), origin_);
   if (ipc_database_id < 0)
@@ skipping 12 matching lines @@
     UMA_HISTOGRAM_MEDIUM_TIMES(
         "WebCore.IndexedDB.OpenTime.UpgradeNeeded",
         base::TimeTicks::Now() - connection_open_start_time_);
     connection_open_start_time_ = base::TimeTicks();
   }
 }
 
 void IndexedDBCallbacks::OnSuccess(
     std::unique_ptr<IndexedDBConnection> connection,
     const IndexedDBDatabaseMetadata& metadata) {
-  DCHECK(dispatcher_host_.get());
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(io_helper_);
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_NE(kNoTransaction, host_transaction_id_);
   DCHECK_NE(ipc_database_id_ == kNoDatabase, !connection);
 
   scoped_refptr<IndexedDBCallbacks> self(this);
 
   int32_t ipc_object_id = kNoDatabase;
   // Only register if the connection was not previously sent in OnUpgradeNeeded.
   if (ipc_database_id_ == kNoDatabase) {
@@ skipping 126 matching lines @@
       iter.mark_used_callback().Run();
   }
   DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::IO));
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback);
 }
 
 void IndexedDBCallbacks::OnSuccess(scoped_refptr<IndexedDBCursor> cursor,
                                    const IndexedDBKey& key,
                                    const IndexedDBKey& primary_key,
                                    IndexedDBValue* value) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(!io_helper_);
-  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
   int32_t ipc_object_id = dispatcher_host_->Add(cursor.get());
   std::unique_ptr<IndexedDBMsg_CallbacksSuccessIDBCursor_Params> params(
       new IndexedDBMsg_CallbacksSuccessIDBCursor_Params());
   params->ipc_thread_id = ipc_thread_id_;
@@ skipping 17 matching lines @@
                                IndexedDBMsg_CallbacksSuccessIDBCursor>,
             base::Owned(params.release()), dispatcher_host_, value->blob_info,
             base::Unretained(&p->value.blob_or_file_info)));
   }
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnSuccess(const IndexedDBKey& key,
                                    const IndexedDBKey& primary_key,
                                    IndexedDBValue* value) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(!io_helper_);
-  DCHECK(dispatcher_host_.get());
 
   DCHECK_NE(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
   IndexedDBCursor* idb_cursor =
       dispatcher_host_->GetCursorFromId(ipc_cursor_id_);
 
   DCHECK(idb_cursor);
@@ skipping 26 matching lines @@
                    value->blob_info,
                    base::Unretained(&p->value.blob_or_file_info)));
   }
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnSuccessWithPrefetch(
     const std::vector<IndexedDBKey>& keys,
     const std::vector<IndexedDBKey>& primary_keys,
     std::vector<IndexedDBValue>* values) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(!io_helper_);
   DCHECK_EQ(keys.size(), primary_keys.size());
   DCHECK_EQ(keys.size(), values->size());
 
-  DCHECK(dispatcher_host_.get());
-
   DCHECK_NE(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
   std::vector<IndexedDBKey> msg_keys;
   std::vector<IndexedDBKey> msg_primary_keys;
 
   for (size_t i = 0; i < keys.size(); ++i) {
     msg_keys.push_back(keys[i]);
@@ skipping 31 matching lines @@
                                        dispatcher_host_,
                                        *values));
   } else {
     dispatcher_host_->Send(
         new IndexedDBMsg_CallbacksSuccessCursorPrefetch(*params.get()));
   }
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnSuccess(IndexedDBReturnValue* value) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(!io_helper_);
-  DCHECK(dispatcher_host_.get());
 
   if (value && value->primary_key.IsValid()) {
     DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   } else {
     DCHECK(kNoCursor == ipc_cursor_id_ || value == NULL);
   }
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
@@ skipping 19 matching lines @@
                    base::Owned(params.release()), dispatcher_host_,
                    value->blob_info,
                    base::Unretained(&p->value.blob_or_file_info)));
   }
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnSuccessArray(
     std::vector<IndexedDBReturnValue>* values,
     const IndexedDBKeyPath& key_path) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(!io_helper_);
-  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
   std::unique_ptr<IndexedDBMsg_CallbacksSuccessArray_Params> params(
       new IndexedDBMsg_CallbacksSuccessArray_Params());
   params->ipc_thread_id = ipc_thread_id_;
   params->ipc_callbacks_id = ipc_callbacks_id_;
   params->values.resize(values->size());
@@ skipping 21 matching lines @@
         base::Bind(BlobLookupForGetAll, base::Owned(params.release()),
                    dispatcher_host_, *values));
   } else {
     dispatcher_host_->Send(
         new IndexedDBMsg_CallbacksSuccessArray(*params.get()));
   }
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnSuccess(const IndexedDBKey& value) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(!io_helper_);
-  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
   dispatcher_host_->Send(new IndexedDBMsg_CallbacksSuccessIndexedDBKey(
       ipc_thread_id_, ipc_callbacks_id_, value));
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnSuccess(int64_t value) {
-  DCHECK(dispatcher_host_.get());
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   if (io_helper_) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&IOThreadHelper::SendSuccessInteger,
                    base::Unretained(io_helper_.get()), value));
   } else {
     DCHECK_EQ(kNoCursor, ipc_cursor_id_);
     DCHECK_EQ(kNoTransaction, host_transaction_id_);
     DCHECK_EQ(kNoDatabase, ipc_database_id_);
     DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
     dispatcher_host_->Send(new IndexedDBMsg_CallbacksSuccessInteger(
         ipc_thread_id_, ipc_callbacks_id_, value));
   }
   dispatcher_host_ = nullptr;
 }
 
 void IndexedDBCallbacks::OnSuccess() {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(dispatcher_host_);
   DCHECK(!io_helper_);
-  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
 
   dispatcher_host_->Send(new IndexedDBMsg_CallbacksSuccessUndefined(
       ipc_thread_id_, ipc_callbacks_id_));
   dispatcher_host_ = nullptr;
 }
@@ skipping 45 matching lines @@
     int32_t database_id,
     const content::IndexedDBDatabaseMetadata& metadata) {
   callbacks_->SuccessDatabase(database_id, metadata);
 }
 
 void IndexedDBCallbacks::IOThreadHelper::SendSuccessInteger(int64_t value) {
   callbacks_->SuccessInteger(value);
 }
 
 }  // namespace content