Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2439593004: Turn on eslint rule key-spacing and fix existing errors. (Closed)

Created:
4 years, 2 months ago by alexandermont
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M .eslintrc View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/dashboard/elements/report-page-test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/input_latency_async_slice_test.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/importer/linux_perf/ftrace_importer.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/v8/v8_log_importer.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/blink/gc_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/v8/gc_metric_test.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/v8/utils.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/helpers/android_model_helper.html View 1 chunk +7 lines, -7 lines 0 comments Download
M tracing/tracing/model/helpers/chrome_model_helper_test.html View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
alexandermont
4 years, 2 months ago (2016-10-20 00:11:11 UTC) #2
charliea (OOO until 10-5)
lgtm Please remove BUG= before submitting (the bug you pointed to isn't relevant)
4 years, 2 months ago (2016-10-20 12:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439593004/1
4 years, 2 months ago (2016-10-20 17:40:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/4845)
4 years, 2 months ago (2016-10-20 18:22:03 UTC) #8
alexandermont
4 years, 2 months ago (2016-10-20 18:27:58 UTC) #10
sullivan
lgtm
4 years, 2 months ago (2016-10-20 19:20:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439593004/1
4 years, 2 months ago (2016-10-20 22:19:20 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 23:43:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698