[Findit] Reduce redundant ndb reads by querying necessary entities ahead of time and share them amo…

appengine/findit/test/findit_api_test.py

Index: appengine/findit/test/findit_api_test.py
diff --git a/appengine/findit/test/findit_api_test.py b/appengine/findit/test/findit_api_test.py
index d10c224c1e567a6ba3d17f7e53958b6775684a1d..d842467dc291a20a2d076ebde253f0e5a816698b 100644
--- a/appengine/findit/test/findit_api_test.py
+++ b/appengine/findit/test/findit_api_test.py
@@ -553,6 +553,11 @@ class FinditApiTest(testing.EndpointsTestCase):
             'total_run': 4,
             'SUCCESS': 2,
             'FAILURE': 2
+        },
+        'Unittest3.Subtest2': {
+            'total_run': 4,
+            'SUCCESS': 2,
+            'FAILURE': 2
         }
     }
     task.put()
@@ -562,6 +567,7 @@ class FinditApiTest(testing.EndpointsTestCase):
     analysis.failure_result_map = {
         'b on platform': {
             'Unittest3.Subtest1': '/'.join([master_name, builder_name, '3']),
+            'Unittest3.Subtest2': '/'.join([master_name, builder_name, '3']),
         },
     }
     analysis.result = {
@@ -577,6 +583,12 @@ class FinditApiTest(testing.EndpointsTestCase):
                         'first_failure': 3,
                         'last_pass': 2,
                         'suspected_cls': []
+                    },
+                    {
+                        'test_name': 'Unittest3.Subtest2',
+                        'first_failure': 3,
+                        'last_pass': 2,
+                        'suspected_cls': []
                     }
                 ]
             }
@@ -596,6 +608,18 @@ class FinditApiTest(testing.EndpointsTestCase):
             'analysis_approach': 'HEURISTIC',
             'is_flaky_test': True,
             'try_job_status': 'FINISHED'
+        },
+        {
+            'master_url': master_url,
+            'builder_name': builder_name,
+            'build_number': build_number,
+            'step_name': 'b on platform',
+            'is_sub_test': True,
+            'test_name': 'Unittest3.Subtest2',
+            'first_known_failed_build_number': 3,
+            'analysis_approach': 'HEURISTIC',
+            'is_flaky_test': True,
+            'try_job_status': 'FINISHED'
         }
     ]
 
@@ -958,4 +982,4 @@ class FinditApiTest(testing.EndpointsTestCase):
 
     response = self.call_api('AnalyzeFlake', body=flake)
     self.assertEqual(200, response.status_int)
-    self.assertTrue(response.json_body.get('analysis_triggered'))
+    self.assertTrue(response.json_body.get('analysis_triggered'))