[Findit] Reduce redundant ndb reads by querying necessary entities ahead of time and share them amo…

appengine/findit/test/findit_api_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import mock
 import re
 
 from google.appengine.api import taskqueue
 import webtest
@@ skipping 535 matching lines @@
             }
         ]
     }
 
     task = WfSwarmingTask.Create(master_name, builder_name, 3, 'b on platform')
     task.tests_statuses = {
         'Unittest3.Subtest1': {
             'total_run': 4,
             'SUCCESS': 2,
             'FAILURE': 2
+        },
+        'Unittest3.Subtest2': {
+            'total_run': 4,
+            'SUCCESS': 2,
+            'FAILURE': 2
         }
     }
     task.put()
 
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.status = analysis_status.COMPLETED
     analysis.failure_result_map = {
         'b on platform': {
             'Unittest3.Subtest1': '/'.join([master_name, builder_name, '3']),
+            'Unittest3.Subtest2': '/'.join([master_name, builder_name, '3']),
         },
     }
     analysis.result = {
         'failures': [
             {
                 'step_name': 'b on platform',
                 'first_failure': 3,
                 'last_pass': 2,
                 'suspected_cls': [],
                 'tests': [
                     {
                         'test_name': 'Unittest3.Subtest1',
                         'first_failure': 3,
                         'last_pass': 2,
                         'suspected_cls': []
+                    },
+                    {
+                        'test_name': 'Unittest3.Subtest2',
+                        'first_failure': 3,
+                        'last_pass': 2,
+                        'suspected_cls': []
                     }
                 ]
             }
         ]
     }
     analysis.put()
 
     expected_results = [
         {
             'master_url': master_url,
             'builder_name': builder_name,
             'build_number': build_number,
             'step_name': 'b on platform',
             'is_sub_test': True,
             'test_name': 'Unittest3.Subtest1',
             'first_known_failed_build_number': 3,
             'analysis_approach': 'HEURISTIC',
             'is_flaky_test': True,
             'try_job_status': 'FINISHED'
+        },
+        {
+            'master_url': master_url,
+            'builder_name': builder_name,
+            'build_number': build_number,
+            'step_name': 'b on platform',
+            'is_sub_test': True,
+            'test_name': 'Unittest3.Subtest2',
+            'first_known_failed_build_number': 3,
+            'analysis_approach': 'HEURISTIC',
+            'is_flaky_test': True,
+            'try_job_status': 'FINISHED'
         }
     ]
 
     self._MockMasterIsSupported(supported=True)
 
     response = self.call_api('AnalyzeBuildFailures', body=builds)
     self.assertEqual(200, response.status_int)
     self.assertEqual(expected_results, response.json_body.get('results'))
 
   @mock.patch.object(suspected_cl_util, 'GetSuspectedCLConfidenceScore')
@@ skipping 342 matching lines @@
                 'master_name': 'm',
                 'builder_name': 'b',
                 'build_number': 456,
                 'step_name': 'name (with patch) on Windows-7-SP1',
             }
         ]
     }
 
     response = self.call_api('AnalyzeFlake', body=flake)
     self.assertEqual(200, response.status_int)
-    self.assertTrue(response.json_body.get('analysis_triggered'))
+    self.assertTrue(response.json_body.get('analysis_triggered'))