Ignore shipping options if requestShipping=false

Ignore shipping options if requestShipping=false

BUG=656911
Committed: https://crrev.com/517454fce947d0e2837499a99f2205322d2462a6
Cr-Commit-Position: refs/heads/master@{#426534}

[please use gerrit instead, 2016-10-19 17:19:12]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-10-19 17:19:18]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-10-19 17:19:41]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2016-10-19 17:19:41]

mathp, ptal.

[commit-bot: I haz the power, 2016-10-19 17:19:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2016-10-19 17:37:02]

lgtm.

Are there plans to test this code eventually? Just curious.

[please use gerrit instead, 2016-10-19 18:37:12]

rouslan@chromium.org changed reviewers:
+ tedchoc@chromium.org

[please use gerrit instead, 2016-10-19 18:37:13]

tedchoc, ptal chrome/android/. I'm adding myself to the OWNERS of the payments
integration tests.

On 2016/10/19 17:37:02, Mathieu Perreault wrote:
> Are there plans to test this code eventually? Just curious.

Added a test and actually figured out that half of the original patch was not
necessary. (It's not possible to trigger that part of code in invalid
configuration.)

[please use gerrit instead, 2016-10-19 19:28:37]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 19:29:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 23:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:38:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ted C, 2016-10-20 15:58:15]

lgtm w/ suggestion

https://codereview.chromium.org/2439543002/diff/60001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/payments/OWNERS
(right):

https://codereview.chromium.org/2439543002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/OWNERS:1:
rouslan@chromium.org
I'd recommend we do the same thing as the junit and make it relative on the
production code directory:

file://chrome/android/java/src/org/chromium/chrome/browser/payments/OWNERS

[please use gerrit instead, 2016-10-20 16:36:01]

Sending to cq.

https://codereview.chromium.org/2439543002/diff/60001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/payments/OWNERS
(right):

https://codereview.chromium.org/2439543002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/OWNERS:1:
rouslan@chromium.org
On 2016/10/20 15:58:15, Ted C wrote:
> I'd recommend we do the same thing as the junit and make it relative on the
> production code directory:
> 
> file://chrome/android/java/src/org/chromium/chrome/browser/payments/OWNERS

Done.

[please use gerrit instead, 2016-10-20 16:36:09]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-10-20 16:36:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2439543002/#ps80001
(title: "Test owners file points to production code owners file")

[commit-bot: I haz the power, 2016-10-20 16:36:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:20:48]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:20:21]

Description was changed from

==========
Ignore shipping options if requestShipping=false

BUG=656911
==========

to

==========
Ignore shipping options if requestShipping=false

BUG=656911

Committed: https://crrev.com/517454fce947d0e2837499a99f2205322d2462a6
Cr-Commit-Position: refs/heads/master@{#426534}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:22]

Patchset 4 (id:??) landed as
https://crrev.com/517454fce947d0e2837499a99f2205322d2462a6
Cr-Commit-Position: refs/heads/master@{#426534}