Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2439543002: Ignore shipping options if requestShipping=false (Closed)
Patch Set: Test owners file points to production code owners file Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/android/payments/payment_request_extra_shipping_options_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
index d7a5ca20b943e31df916e31cf9a5a9ebc830737e..8d7df86411f1a2f49960ad1f34dd66b9e2c6e8ff 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
@@ -639,8 +639,9 @@ PaymentRequest::PaymentRequest(ScriptState* scriptState,
m_clientBinding.CreateInterfacePtrAndBind(),
mojo::WTFArray<mojom::blink::PaymentMethodDataPtr>::From(
validatedMethodData),
- maybeKeepShippingOptions(mojom::blink::PaymentDetails::From(details),
- keepShippingOptions),
+ maybeKeepShippingOptions(
+ mojom::blink::PaymentDetails::From(details),
+ keepShippingOptions && m_options.requestShipping()),
mojom::blink::PaymentOptions::From(m_options));
}
« no previous file with comments | « chrome/test/data/android/payments/payment_request_extra_shipping_options_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698