Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5649)

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 2439493002: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/lifetime/keep_alive_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_service.cc
diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc
index 4437b54d108e40c9691a0789fe3473d65a794641..ea4f28470e2edb3876db1b9d0a6528a6b11ac16b 100644
--- a/chrome/browser/engagement/site_engagement_service.cc
+++ b/chrome/browser/engagement/site_engagement_service.cc
@@ -434,9 +434,8 @@ void SiteEngagementService::HandleMediaPlaying(
: SiteEngagementScore::GetVisibleMediaPoints());
RecordMetrics();
- FOR_EACH_OBSERVER(
- SiteEngagementObserver, observer_list_,
- OnEngagementIncreased(web_contents, url, GetScore(url)));
+ for (SiteEngagementObserver& observer : observer_list_)
+ observer.OnEngagementIncreased(web_contents, url, GetScore(url));
}
void SiteEngagementService::HandleNavigation(content::WebContents* web_contents,
@@ -448,9 +447,8 @@ void SiteEngagementService::HandleNavigation(content::WebContents* web_contents,
AddPoints(url, SiteEngagementScore::GetNavigationPoints());
RecordMetrics();
- FOR_EACH_OBSERVER(
- SiteEngagementObserver, observer_list_,
- OnEngagementIncreased(web_contents, url, GetScore(url)));
+ for (SiteEngagementObserver& observer : observer_list_)
+ observer.OnEngagementIncreased(web_contents, url, GetScore(url));
}
}
@@ -462,9 +460,8 @@ void SiteEngagementService::HandleUserInput(
AddPoints(url, SiteEngagementScore::GetUserInputPoints());
RecordMetrics();
- FOR_EACH_OBSERVER(
- SiteEngagementObserver, observer_list_,
- OnEngagementIncreased(web_contents, url, GetScore(url)));
+ for (SiteEngagementObserver& observer : observer_list_)
+ observer.OnEngagementIncreased(web_contents, url, GetScore(url));
}
bool SiteEngagementService::IsLastEngagementStale() const {
« no previous file with comments | « no previous file | chrome/browser/lifetime/keep_alive_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698