Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2438983002: Revert of Update implementation of atomics with latest Chromium version but use compiler builtin atomics (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Update implementation of atomics with latest Chromium version but use compiler builtin atomics (patchset #10 id:190001 of https://chromiumcodereview.appspot.com/2425963002/ ) Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20-%20builder/builds/4851 Original issue's description: > Update implementation of atomics with latest Chromium version but use compiler builtin atomics > > Ideally, we would use the standard library. However, when we are compiling against an older version of the standard library the atomic implementation may be slow. > > BUG= TBR=mlippautz@chromium.org,ulan@chromium.org,jarin@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6e162add3e6404d560049673fdd0ef4f6f2cf95d Cr-Commit-Position: refs/heads/master@{#40489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2484 lines, -196 lines) Patch
M BUILD.gn View 1 chunk +9 lines, -1 line 0 comments Download
M src/base/atomicops.h View 3 chunks +27 lines, -14 lines 0 comments Download
A src/base/atomicops_internals_arm64_gcc.h View 1 chunk +317 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_arm_gcc.h View 1 chunk +304 lines, -0 lines 0 comments Download
M src/base/atomicops_internals_atomicword_compat.h View 2 chunks +10 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_mac.h View 1 chunk +216 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_mips64_gcc.h View 1 chunk +310 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_mips_gcc.h View 1 chunk +161 lines, -0 lines 0 comments Download
D src/base/atomicops_internals_portable.h View 1 chunk +0 lines, -172 lines 0 comments Download
A src/base/atomicops_internals_ppc_gcc.h View 1 chunk +168 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_s390_gcc.h View 1 chunk +152 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_tsan.h View 1 chunk +363 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_x86_gcc.h View 1 chunk +278 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_x86_gcc.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M src/base/atomicops_internals_x86_msvc.h View 7 chunks +33 lines, -8 lines 0 comments Download
M src/v8.gyp View 1 chunk +10 lines, -1 line 0 comments Download
M test/cctest/test-atomicops.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Michael Achenbach
4 years, 2 months ago (2016-10-21 08:09:34 UTC) #2
Created Revert of Update implementation of atomics with latest Chromium version
but use compiler builtin atomics

Powered by Google App Engine
This is Rietveld 408576698