Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2438853002: Renames aura::client::WindowTreeClient to WindowParentingClient (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, shuchen+watch_chromium.org, dcheng, sievers+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, qsr+mojo_chromium.org, maniscalco+watch-blimp_chromium.org, Aaron Boodman, bgoldman+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, James Su, darin (slow to review), khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, tfarina, steimel+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames aura::client::WindowTreeClient to WindowParentingClient This way it won't conflict with ui::WindowTreeClient, which we want to move to aura. BUG=none TEST=rename only R=ben@chromium.org Committed: https://crrev.com/28f20d6f553d7ddc0ea1cf52f31d6e6e2ded7b3a Cr-Commit-Position: refs/heads/master@{#426642}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -439 lines) Patch
M ash/aura/wm_window_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + blimp/engine/app/ui/blimp_window_parenting_client.h View 2 chunks +9 lines, -9 lines 0 comments Download
A blimp/engine/app/ui/blimp_window_parenting_client.cc View 1 chunk +32 lines, -0 lines 0 comments Download
D blimp/engine/app/ui/blimp_window_tree_client.h View 1 chunk +0 lines, -35 lines 0 comments Download
D blimp/engine/app/ui/blimp_window_tree_client.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.h View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_platform_data_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_screen.h View 1 chunk +1 line, -1 line 0 comments Download
A headless/lib/browser/headless_window_parenting_client.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_window_parenting_client.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
D headless/lib/browser/headless_window_tree_client.h View 1 chunk +0 lines, -30 lines 0 comments Download
D headless/lib/browser/headless_window_tree_client.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M ui/aura/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/aura/client/window_parenting_client.h View 4 chunks +14 lines, -13 lines 0 comments Download
A + ui/aura/client/window_parenting_client.cc View 2 chunks +14 lines, -11 lines 0 comments Download
D ui/aura/client/window_tree_client.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/aura/client/window_tree_client.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/aura/test/test_window_parenting_client.h View 2 chunks +9 lines, -9 lines 0 comments Download
A ui/aura/test/test_window_parenting_client.cc View 1 chunk +28 lines, -0 lines 0 comments Download
D ui/aura/test/test_window_tree_client.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/aura/test/test_window_tree_client.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/shadow_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/transient_window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/test/wm_test_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years, 2 months ago (2016-10-20 20:24:41 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 2 months ago (2016-10-20 22:59:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438853002/20001
4 years, 2 months ago (2016-10-20 23:02:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 23:22:26 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:24:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28f20d6f553d7ddc0ea1cf52f31d6e6e2ded7b3a
Cr-Commit-Position: refs/heads/master@{#426642}

Powered by Google App Engine
This is Rietveld 408576698