Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2438673006: [wasm] GrowMemory should update imported memory objects. (Closed)

Created:
4 years, 2 months ago by gdeepti
Modified:
4 years, 1 month ago
Reviewers:
titzer, Derek Schuff
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] GrowMemory should update imported memory objects. When the instance has imported memory, calling GrowMemory should update the memory object to have a consistent view of the memory. This fixes the failing emscripten test case, added a reduced test that simulates the same behavior. R=titzer@chromium.org, dschuff@chromium.org Committed: https://crrev.com/5afa8ed77afc9118c5da9bc31c31cae49d2d993e Cr-Commit-Position: refs/heads/master@{#40490}

Patch Set 1 #

Patch Set 2 : Improve test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M src/wasm/wasm-js.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/wasm-js.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/import-memory.js View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
gdeepti
4 years, 2 months ago (2016-10-21 06:26:20 UTC) #5
titzer
lgtm, thanks!
4 years, 2 months ago (2016-10-21 07:51:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438673006/20001
4 years, 2 months ago (2016-10-21 08:08:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 08:38:44 UTC) #11
Derek Schuff
On 2016/10/21 08:38:44, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) Cool! ...
4 years, 2 months ago (2016-10-21 15:49:43 UTC) #12
gdeepti
On 2016/10/21 15:49:43, Derek Schuff wrote: > On 2016/10/21 08:38:44, commit-bot: I haz the power ...
4 years, 2 months ago (2016-10-21 17:10:36 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:09:07 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5afa8ed77afc9118c5da9bc31c31cae49d2d993e
Cr-Commit-Position: refs/heads/master@{#40490}

Powered by Google App Engine
This is Rietveld 408576698