[Offline pages] Add MarkAttemptAbortedTask to Request Queue

[Offline pages] Add MarkAttemptAbortedTask to Request Queue

This patch:
* Generalizes and extracts Update Request Task,
* Adds mark attempt aborted task
* Adds tests for mark attempt aborted task
* Applies MarkAttemptAbortedTask in Task queue and request coordinator

BUG=651238
Committed: https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c
Cr-Commit-Position: refs/heads/master@{#426694}

[fgorski, 2016-10-19 17:10:45]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[fgorski, 2016-10-19 17:11:17]

fgorski@chromium.org changed reviewers:
+ dougarnett@chromium.org, petewil@chromium.org

[fgorski, 2016-10-19 17:11:17]

PTAL.

[commit-bot: I haz the power, 2016-10-19 17:11:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 19:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 19:11:18]

Dry run: This issue passed the CQ dry run.

[dougarnett, 2016-10-19 21:23:10]

lgtm with doc comments

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
File components/offline_pages/background/mark_attempt_aborted_task_unittest.cc
(right):

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
components/offline_pages/background/mark_attempt_aborted_task_unittest.cc:101:
MarkAttemptStartedTask start_request_task(
// First mark the request as started.

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
File components/offline_pages/background/update_request_task.h (right):

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
components/offline_pages/background/update_request_task.h:18: class
UpdateRequestTask : public Task {
doc? base class for updating a request?

[fgorski, 2016-10-20 16:56:03]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[fgorski, 2016-10-20 16:56:34]

Addressed.

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
File components/offline_pages/background/mark_attempt_aborted_task_unittest.cc
(right):

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
components/offline_pages/background/mark_attempt_aborted_task_unittest.cc:101:
MarkAttemptStartedTask start_request_task(
On 2016/10/19 21:23:10, dougarnett wrote:
> // First mark the request as started.

Done.

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
File components/offline_pages/background/update_request_task.h (right):

https://codereview.chromium.org/2438503003/diff/20001/components/offline_page...
components/offline_pages/background/update_request_task.h:18: class
UpdateRequestTask : public Task {
On 2016/10/19 21:23:10, dougarnett wrote:
> doc? base class for updating a request?

Done.

[commit-bot: I haz the power, 2016-10-20 16:56:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:28:52]

Dry run: This issue passed the CQ dry run.

[Pete Williamson, 2016-10-21 00:25:23]

lgtm

[fgorski, 2016-10-21 02:12:02]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-10-21 02:12:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dougarnett@chromium.org
Link to the patchset: https://codereview.chromium.org/2438503003/#ps40001
(title: "Addressing feedback -- adding comments and documentation")

[commit-bot: I haz the power, 2016-10-21 02:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 02:24:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:26:16]

Description was changed from

==========
[Offline pages] Add MarkAttemptAbortedTask to Request Queue

This patch:
* Generalizes and extracts Update Request Task,
* Adds mark attempt aborted task
* Adds tests for mark attempt aborted task
* Applies MarkAttemptAbortedTask in Task queue and request coordinator

BUG=651238
==========

to

==========
[Offline pages] Add MarkAttemptAbortedTask to Request Queue

This patch:
* Generalizes and extracts Update Request Task,
* Adds mark attempt aborted task
* Adds tests for mark attempt aborted task
* Applies MarkAttemptAbortedTask in Task queue and request coordinator

BUG=651238

Committed: https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c
Cr-Commit-Position: refs/heads/master@{#426694}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:17]

Patchset 3 (id:??) landed as
https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c
Cr-Commit-Position: refs/heads/master@{#426694}