Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: components/offline_pages/background/update_request_task.h

Issue 2438503003: [Offline pages] Add MarkAttemptAbortedTask to Request Queue (Closed)
Patch Set: Addressing feedback -- adding comments and documentation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/update_request_task.h
diff --git a/components/offline_pages/background/update_request_task.h b/components/offline_pages/background/update_request_task.h
new file mode 100644
index 0000000000000000000000000000000000000000..ad332bd9bb0ceb6b0d64118422a994b3ed2b4664
--- /dev/null
+++ b/components/offline_pages/background/update_request_task.h
@@ -0,0 +1,66 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_UPDATE_REQUEST_TASK_H_
+#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_UPDATE_REQUEST_TASK_H_
+
+#include <stdint.h>
+
+#include <memory>
+
+#include "base/memory/weak_ptr.h"
+#include "components/offline_pages/background/request_queue_store.h"
+#include "components/offline_pages/core/task.h"
+
+namespace offline_pages {
+
+// Base class for update requests that only work on a single save page request.
+// Derived classes should implement appropriate functionality by overloading
+// |UpdateRequestImpl| method.
+class UpdateRequestTask : public Task {
+ public:
+ UpdateRequestTask(RequestQueueStore* store,
+ int64_t request_id,
+ const RequestQueueStore::UpdateCallback& callback);
+ ~UpdateRequestTask() override;
+
+ // TaskQueue::Task implementation.
+ void Run() override;
+
+ protected:
+ // Step 1. Reading the requests.
+ void ReadRequest();
+ // Step 2. Work is done in the implementation step.
+ virtual void UpdateRequestImpl(
+ std::unique_ptr<UpdateRequestsResult> result) = 0;
+ // Step 3. Completes once update is done.
+ void CompleteWithResult(std::unique_ptr<UpdateRequestsResult> result);
+
+ // Function to uniformly validate read request call for store errors and
+ // presence of the request.
+ bool ValidateReadResult(UpdateRequestsResult* result);
+
+ RequestQueueStore* store() const { return store_; }
+
+ int64_t request_id() const { return request_id_; }
+
+ base::WeakPtr<UpdateRequestTask> GetWeakPtr() {
+ return weak_ptr_factory_.GetWeakPtr();
+ }
+
+ private:
+ // Store that this task updates. Not owned.
+ RequestQueueStore* store_;
+ // Request ID of the request to be started.
+ int64_t request_id_;
+ // Callback to complete the task.
+ RequestQueueStore::UpdateCallback callback_;
+
+ base::WeakPtrFactory<UpdateRequestTask> weak_ptr_factory_;
+ DISALLOW_COPY_AND_ASSIGN(UpdateRequestTask);
+};
+
+} // namespace offline_pages
+
+#endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_UPDATE_REQUEST_TASK_H_

Powered by Google App Engine
This is Rietveld 408576698