components/offline_pages/offline_page_model_impl.cc - Issue 2437813002: [Offline pages] Dropping bburns from TODOs and histogram ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2437813002: [Offline pages] Dropping bburns from TODOs and histogram ownership (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/offline_page_model_impl.cc

diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc

index 0a5094fb876b41b3e04a0327b3c3871d1ad70f10..3e300dd2b16b13cbb8b550ae5f64b6db2cafd4ac 100644

--- a/components/offline_pages/offline_page_model_impl.cc

+++ b/components/offline_pages/offline_page_model_impl.cc

@@ -526,7 +526,7 @@ const std::vector<int64_t> OfflinePageModelImpl::MaybeGetOfflineIdsForClientId(

std::vector<int64_t> results;

// We want only all pages, including those marked for deletion.

- // TODO(bburns): actually use an index rather than linear scan.

+ // TODO(fgorski): actually use an index rather than linear scan.

for (const auto& id_page_pair : offline_pages_) {

if (id_page_pair.second.client_id == client_id &&

!id_page_pair.second.IsExpired()) {