Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: components/offline_pages/offline_page_metadata_store_sql.cc

Issue 2437813002: [Offline pages] Dropping bburns from TODOs and histogram ownership (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/offline_page_model_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_metadata_store_sql.cc
diff --git a/components/offline_pages/offline_page_metadata_store_sql.cc b/components/offline_pages/offline_page_metadata_store_sql.cc
index 7e22cd176398c354bfed36fb277db12db2c5cb2c..80061980d55d58f742b9bfecc9923f93021f6c6b 100644
--- a/components/offline_pages/offline_page_metadata_store_sql.cc
+++ b/components/offline_pages/offline_page_metadata_store_sql.cc
@@ -123,7 +123,7 @@ bool CreateSchema(sql::Connection* db) {
return false;
}
- // TODO(bburns): Add indices here.
+ // TODO(fgorski): Add indices here.
return transaction.Commit();
}
@@ -258,7 +258,7 @@ void NotifyLoadResult(scoped_refptr<base::SingleThreadTaskRunner> runner,
const OfflinePageMetadataStore::LoadCallback& callback,
OfflinePageMetadataStore::LoadStatus status,
const std::vector<OfflinePageItem>& result) {
- // TODO(bburns): Switch to SQL specific UMA metrics.
+ // TODO(fgorski): Switch to SQL specific UMA metrics.
UMA_HISTOGRAM_ENUMERATION("OfflinePages.LoadStatus", status,
OfflinePageMetadataStore::LOAD_STATUS_COUNT);
if (status == OfflinePageMetadataStore::LOAD_SUCCEEDED) {
« no previous file with comments | « no previous file | components/offline_pages/offline_page_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698